Interrupt Server Thread When Client Is Killed about nailgun

[martylamb]

Sounds like a great change - a patch is welcome! Thanks much.

[jimpurbrick]

RFC commit here jimpurbrick@4f48129

Adds support for context.isClientRunning() by adding heartbeats and basic flow control to the protocol.

Needs testing and probably fixing on Windows and cleaning up (what indentation would you like me to use?).

[jimpurbrick]

Any thoughts on the diff @martylamb? Would you or Pete Kirkham be able to do the windows port?

[jimpurbrick]

A few things I've been thinking about: 1) it would be nice to have a way for nails to register a callback which is run when the client disconnects to avoid cases where they have to spin up a thread just to poll isClientRunning (I favour just passing in a Runnable, but we could use a listener) 2) the scheduler in the NGInputStream should probably be static and shared by all streams to avoid 1 extra thread per connection which is mostly asleep 3) we might need to make recv timeout as well as select to be safe 4) the windows port will probably have to use WaitForMultipleObjects so that it can be triggered by stdin or the nailgun socket or a timeout in a similar way to select.

[jimpurbrick]

A new commit that addresses 1) and 2) jimpurbrick@23ddda7

Still need to wrangle windows support and would love some help with that.

[martylamb]

Hi Jim -

Just wanted to let you know that I've blocked off some time on Wednesday
night to take a look.

Thanks again!

• Marty

On Mon, Sep 23, 2013 at 1:45 PM, Jim Purbrick [email protected]:

A new commit that addresses 1) and 2) jimpurbrick/nailgun@23ddda7jimpurbrick@23ddda7

Still need to wrangle windows support and would love some help with that.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-24938572
.

[jimpurbrick]

I've submitted a pull request (#15) that includes a couple of changes that fix win32 support and a race condition in the server that should be merged as those bugs are currently in master

[sbalabanov-zz]

Closing all issues older than 6 months; please reopen if it is still relevant