Comments (7)
In case this affects your interest in attempting to fix the problem and submit a pull request, Facebook MySQL engineering has stopped investing in improvements to InnoDB compression and are considering removing our compression commits next time we rebase to an upstream MySQL 5.6 point release (5.6.24 or 5.6.25).
from mysql-5.6.
Doesn't affect my plans; I have ported 5bd4269 to Percona Server where we need the feature, and I have the fix already
from mysql-5.6.
I don't know how to make a pull request from a mysql/mysql-server fork to your repo even if I took the right base branch etc. Given what Justin wrote, I'll stop there, here's the commit, which you can consider as a pull request if interested:
laurynas-biveinis/percona-server@2ba305a
from mysql-5.6.
Thank you for providing a link to the fix. I will determine whether to incorporate it when I look more in depth about removing our compression diffs in the next rebase.
from mysql-5.6.
Laurynas, I was planning to pick up your proposed change, but it doesn't look to me like you've signed our CLA, https://code.facebook.com/cla. Would you be willing to do so?
Cheers,
Justin
from mysql-5.6.
Done
from mysql-5.6.
I just pushed webscalesql-5.6.24.97. In that branch, I incorporated your changes and squashed it with the commit you identified as introducing the problem. See 750dd658.
FYI: I had to stabilize the new tests you added by adding --force-restart to the opt files and --source include/have_innodb_16k.inc to the .test files.
from mysql-5.6.
Related Issues (20)
- How to achieve ~20% replication throughput improvement using Read Free Replication (RFR) feature
- Keep long-running MyRocks mtr tests in their own suite HOT 1
- MyRocks 8.0.28 has poor performance of primary key range query HOT 1
- create secondary index needs attention
- issue while install HOT 1
- Error during create secondary index
- Update the Build Steps page HOT 1
- MyRocks engine should respect WITH_UNIT_TESTS
- Allow users to manually set the number of block cache shards HOT 1
- Provide a counter to show pending compaction bytes for RocksDB
- MyRocks does commit step non-durably under server group 2PC protocol HOT 1
- alter talbe add index optimization
- Range lock support HOT 2
- Cached RocksDB transaction object accessed after delete by XA COMMIT
- optimize table has no effect on HIDDEN_PK table
- Rdb_iterator_base::next_with_direction: too many compares for eof check HOT 2
- Determin secondary index value emptiness by datadic
- undefined reference to `sgemm_' When compiling vector DB
- -DWITH_LZ4=system doesn't find the lz4 library on the fb-mysql-8.0.28 branch
- is_thd_db_read_only_by_name CPU overhead can be reduce
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mysql-5.6.