innochecksum fails on compressed tables with key_block_size=16 about mysql-5.6

[jtolmer]

In case this affects your interest in attempting to fix the problem and submit a pull request, Facebook MySQL engineering has stopped investing in improvements to InnoDB compression and are considering removing our compression commits next time we rebase to an upstream MySQL 5.6 point release (5.6.24 or 5.6.25).

[laurynas-biveinis]

Doesn't affect my plans; I have ported 5bd4269 to Percona Server where we need the feature, and I have the fix already

[laurynas-biveinis]

I don't know how to make a pull request from a mysql/mysql-server fork to your repo even if I took the right base branch etc. Given what Justin wrote, I'll stop there, here's the commit, which you can consider as a pull request if interested:

laurynas-biveinis/percona-server@2ba305a

[jtolmer]

Thank you for providing a link to the fix. I will determine whether to incorporate it when I look more in depth about removing our compression diffs in the next rebase.

[jtolmer]

Laurynas, I was planning to pick up your proposed change, but it doesn't look to me like you've signed our CLA, https://code.facebook.com/cla. Would you be willing to do so?

Cheers,

Justin

[laurynas-biveinis]

Done

[jtolmer]

I just pushed webscalesql-5.6.24.97. In that branch, I incorporated your changes and squashed it with the commit you identified as introducing the problem. See 750dd658.

FYI: I had to stabilize the new tests you added by adding --force-restart to the opt files and --source include/have_innodb_16k.inc to the .test files.