flush_all doesn't work about mcrouter

[0xd3adsh3ll]

I tried to clear the cache with command:
echo -ne "flush_all\r\n" | nc 0 5000
SERVER_ERROR Command not supported
But get an error.

Also, my php app can't reset cache via memcache: http://php.net/manual/en/memcache.flush.php

php_app (do action reset_cache)
|
| -- php_method (Memcache::flush ( mcrouter.local:5001 ))
|
| -- part of syslog error: [2015-02-16 13:40:18] project.ERROR: could not connect to memcache {"host":"mcrouter.local","port":5001.....

Can you provide information about rules "how to flush_all/flush_regex via mcrouter", please?
I see of your code:
[mc_op_flushall] = 22 /* flush_all \r\n /,
[mc_op_flushre] = 14 / flush_regex \r\n /,
[mc_op_stats] = 8 / stats \r\n */,
Why some of commands works fine (e.g. stats) but some of those doesn't work?

[pavlo-fb]

@0xd3adsh3ll thanks for the report. We explicitly disabled flush_all and flush_regex commands, because it may be very destructive to replicate them via mcrouter (it is very easy to break everything if some broken script sends those commands to production boxes). See https://github.com/facebook/mcrouter/blob/master/mcrouter/McrouterClient.cpp#L33

What is your use case? If it is only for debugging/testing, we can add the support, but guard it with some command line option (like --enable-flush-command or --debug-mode).

[0xd3adsh3ll]

Hello, @pavlo-fb,
Memcache::flush needs for new releases of our projects:

ansible
|
|-- production_servers (remove old code, create new release folder, prepare env)
|-- control_panel (clear all cached data after release because we stored some temporary settings in cache which must be removed.)

I have question, if send flush_all directly on memcached servers bypassing mcrouter? It's possible?
Thanks.

|--

[ryanmce]

Yes, mcrouter doens't modify the behavior of memcached at all, so if you
send a flush all command directly to the memcached server, it will behave
normally.

On Tue, Feb 17, 2015 at 10:10 PM, 0xd3adsh3ll [email protected]
wrote:

Hello, @pavlo-fb https://github.com/pavlo-fb,
Memcache::flush needs for new releases of our projects:

ansible
|
|-- production_servers (remove old code, create new release folder,
prepare env)
|-- control_panel (clear all cached data after release because we stored
some temporary settings in cache which must be removed.)

I have question, if send flush_all directly on memcached servers bypassing
mcrouter? It's possible?
Thanks.

|--

—
Reply to this email directly or view it on GitHub
#29 (comment).

[0xd3adsh3ll]

@ryanmce, thanks!
If @pavlo-fb can enable: "If it is only for debugging/testing, we can add the support, but guard it with some command line option (like --enable-flush-command or --debug-mode)" It's be a perfectly.

[0xd3adsh3ll]

Hello, @pavlo-fb, @ryanmce tell me please, you can enable "--enable-flush-command"?
Thanks.

[andreazevedo]

Hello @0xd3adsh3ll,
As @pavlo-fb said, these commands are very dangerous to be replicated via mcrouter. You should consider bypassing mcrouter for these specific statements and sending it straight to the memcached box you intend too.
That being said, if you really think you need/want to use these commands with mcrouter, let me know and I will re-prioritize and get this done for you sooner rather than later.
Thanks.

[0xd3adsh3ll]

Hello @andreazevedo,
Thanks for your reply, I understand the risk but could you please enable "flush_all" via mcrouter, this need for our project.
Thanks.

[andreazevedo]

Hello @0xd3adsh3ll,
We just pushed a new version of mcrouter that adds support to flush_all (commit 3cb8ca2). You just need to specify the --enable-flush-cmd command-line option.

[0xd3adsh3ll]

Hello @andreazevedo,
Thanks a lot :)
I'm close this ticket. You are awesome! :)