Query on writing custom sinks about mariana-trench

[gitWK86]

for all parameters

Argument(0) here represents the string object itself,which is not params.

I guess for all parameters represents the parameters of the contains function.

e.g, "abc".contains(argument1)
I guess "abc" is Argument(0), for all parameters may only represent argument1

[gitWK86]

@chuayupeng

getIntent().getData().getHost() is sink , not string "sink".

Argument(0) is a reference to a string object， in this case "getIntent().getData().getHost()"

BypassableHostCheck.json change to ->

{
  "model_generators": [
    {
      "find": "methods",
      "where": [
        {
          "constraint": "parent",
          "inner": {
            "constraint": "name",
            "pattern": "Ljava/lang/String;"
          }
        },
        {
          "constraint": "any_of",
          "inners": [
            {
              "constraint": "name",
              "pattern": "contains"
            },
            {
              "constraint": "name",
              "pattern": "endsWith"
            }
          ]
        }
      ],
      "model": {
        "sinks": [
          {
            "kind": "BypassableHostCheck",
            "port": "Argument(0)"
          }
        ]
      },
      "verbosity": 1
    }
  ]
}

the rules.json like ->

[
  {
    "name": "BypassableHostCheck",
    "code": 7,
    "description": "BypassableHostCheck",
    "sources": [
      "FragmentUserInput",
      "ActivityUserInput",
      "ProviderUserInput",
      "ReceiverUserInput",
      "ServiceUserInput"
    ],
    "sinks": [
      "BypassableHostCheck"
    ]
  }
]

[chuayupeng]

@gitWK86 thanks! the change to Argument(0) worked, but just a bit confused as to why the for all parameters did not work in this case

[chuayupeng]

Sounds about right! Thanks, will keep that in mind moving forward :D