Comments (4)
It could helpful if you could give directly in your issue some concrete numbers for the potential win.
Sure. I cannot give you right now the potential win numbers for Mariana-Trench itself (since I didn't integrate the PGO in it yet). But as an estimation I can suggest you my results for Clang-Tidy. It's also a static analysis tool so Clang-Tidy's result should be relevant here. If one day I get the results for Mariana-Trench - definitely I will post them here.
I personally found it a bit hard to navigate your repository with hundreds of links
Thanks for the feedback! Right now I am trying to figure out, what is the better way to present all this information. So for now I can suggest navigating over Ctrl+F with the name of your project (like "Clang"). Also, I've tried to group the links of similar projects (similar == the same domain) into one place like "Compilers", "Operating systems", etc. Hope it helps.
some are broken for me, for instance the one for Firefox results
Could you please give me this link? I just rechecked all Firefox links - they work fine. I guess it could be a link to Google Groups, that does not allow unauthenticated access or something like that. But I will wait for a bit more information for debugging this issue.
For instance, it took me a while to find instructions to build our project with PGO and Clang.
Thanks! I will try to fix this.
Knowing that the performance win is not guaranteed, it seems like a risky project to take on.
Definitely is not guaranteed. But at least according to my tests, PGO shows improvements in all tested by me compiler-like workloads (static analysis, compilers, LSP implementations, even formatters). So you can estimate some performance wins based on the benchmarks for other projects.
NB: I can't help but notice that you opened a similar issue on more than 90 repositories. That feels a bit spammy. Not sure if there was a better way to do it.
Me too. Honestly, I do not think that it's "bad" spamming or something like that. I see many cases (like one, two, three) where people actually thanks for raising the optimization opportunity.
So I decided just speak with project maintainers via issues. Some are interested in PGO and we are discussing it further, some are not interested in performance (and it's completely ok - every project on every lifecycle stage has own priorities) and close the PGO-related issues. Also, via issues I collect feedback about my results (like you did with reporting for difficult navigation over the repo).
from mariana-trench.
Sure, PGO and LLVM BOLT are great. We could try LTO as well.
Some feedback for your issue and your repository:
- It could helpful if you could give directly in your issue some concrete numbers for the potential win.
- I personally found it a bit hard to navigate your repository with hundreds of links (some are broken for me, for instance the one for Firefox results). For instance, it took me a while to find instructions to build our project with PGO and Clang.
Regarding implementing PGO for this project: the setup seems non-trivial (not quite mature) and integrating it in our build system will be complicated (we have 2 of those, actually). Knowing that the performance win is not guaranteed, it seems like a risky project to take on.
NB: I can't help but notice that you opened a similar issue on more than 90 repositories. That feels a bit spammy. Not sure if there was a better way to do it.
from mariana-trench.
some are broken for me, for instance the one for Firefox results
Could you please give me this link? I just rechecked all Firefox links - they work fine. I guess it could be a link to Google Groups, that does not allow unauthenticated access or something like that. But I will wait for a bit more information for debugging this issue.
oh right, it's just because we have some kind of corporate Google account which doesn't allow access to Google groups.
Link I was talking about: https://groups.google.com/g/mozilla.dev.platform/c/wwO48xXFx0A/m/ztg4i0DYAAAJ
from mariana-trench.
Got it. I will extract the results directly to the repo for this case. Thanks!
from mariana-trench.
Related Issues (20)
- [Question] Difference between attach_to_sources and features keys. HOT 4
- Does not compile with latest fmt 9.1 due to lack of formatter for types HOT 1
- How to check argument value with regex? HOT 1
- The latest version compiles, cannot be used, and various parameters are missing. MarianaTrench mariana_trench_error: the option '--output-directory' is required but missing???
- Example code does not work HOT 3
- Taint not flowing into a sink in Runnable
- Build from source fails. HOT 1
- Stuck creating generators: Found 0 issues
- Old macOS 10.15.7 failed to execute analysis HOT 4
- Tainted data not flowing through custom propagations HOT 14
- "No such file " log in sapp HOT 3
- Request for Features Description HOT 3
- Release app with proguard HOT 1
- Error building mariana-trench HOT 1
- verifying propagations applied to the functions. HOT 2
- ImportError when using sapp HOT 3
- Default model generators missing from PyPI release HOT 2
- Flow analysis in a method.
- Sanitizer does not work, or something wrong
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mariana-trench.