Coder Social home page Coder Social logo

Comments (5)

manishbisht avatar manishbisht commented on May 4, 2024

I am interested in working this issue. Can I put the helper function in the RuleUtils.js ?

from instant-articles-builder.

pestevez avatar pestevez commented on May 4, 2024

Thanks for your interest to work on this, @manishbisht. RuleUtils.js looks like a good place for a helper function; so I'd be happy to a review a pull request.

Also, you could also create a separate React component that uses the helper function. Just a thought, though...

from instant-articles-builder.

manishbisht avatar manishbisht commented on May 4, 2024

Exactly !! Component will look much better. I was thinking about the same.

from instant-articles-builder.

manishbisht avatar manishbisht commented on May 4, 2024

@pestevez I have added the RuleLabel Component and can you review the PR.

Once it is approved my next task will be to create a helped function in RuleUtils.js and then use the helper function to get the level so that the repeated code can be removed.

from instant-articles-builder.

manishbisht avatar manishbisht commented on May 4, 2024

@pestevez I have added the component. I don't think we need the helper function now. Can you review the PR and let me know if it is still needed.

from instant-articles-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.