Coder Social home page Coder Social logo

JSX Support short bool syntax about fbt HOT 7 CLOSED

facebook avatar facebook commented on May 8, 2024
JSX Support short bool syntax

from fbt.

Comments (7)

jrwats avatar jrwats commented on May 8, 2024 1

OK, you are clear for takeoff :)
#84

Try running yarn test from the top-level repo after rebasing

I'd recommend adding some tests using your new syntax similar to:
https://github.com/facebookincubator/fbt/blob/9963128994dadbf1f8c362ee13e313f66787df0e/packages/babel-plugin-fbt/__tests__/fbtJsx-test.js#L870-L881

from fbt.

jrwats avatar jrwats commented on May 8, 2024

It's valid JSX, we probably ought to support it.

from fbt.

retyui avatar retyui commented on May 8, 2024

The same problem:

  <fbt:param name="name" number>{person.getName()}</fbt:param>

from fbt.

jrwats avatar jrwats commented on May 8, 2024

@retyui , are you interested in adding this support in a PR? It should be a matter of updating:

https://github.com/facebookincubator/fbt/blob/master/packages/babel-plugin-fbt/FbtUtil.js#L130-L155

from fbt.

retyui avatar retyui commented on May 8, 2024

I do not know how run tests )

from fbt.

jrwats avatar jrwats commented on May 8, 2024

Standby @retyui, we'll support tests "soon" cc @w1106c
#86

from fbt.

jrwats avatar jrwats commented on May 8, 2024

8ba8802

from fbt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.