Coder Social home page Coder Social logo

npm'd version fails flow about fbjs HOT 4 CLOSED

facebook avatar facebook commented on July 27, 2024
npm'd version fails flow

from fbjs.

Comments (4)

jaredly avatar jaredly commented on July 27, 2024

Maybe a reasonable fix would be to include the un-transpiled code as well in the npm version, so that flow/babel-using clients can use the original stuff.

from fbjs.

zpao avatar zpao commented on July 27, 2024

KP that we're working through. See #17. cc @yungsters

Including the uncompiled code was discussed but module resolution gets tricky. It's doable but a bit messy.

from fbjs.

yungsters avatar yungsters commented on July 27, 2024

Until Flow Comments is more stable, figuring out a solution involving packaging the un-transpiled code seems like a good idea. GraphQL is also running into this right now.

cc @dschafer @leebyron

from fbjs.

leebyron avatar leebyron commented on July 27, 2024

As of v0.2.0, GraphQL-js is now using https://github.com/babel-plugins/babel-plugin-flow-comments

from fbjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.