reletavise requires in compiled .flow files about fbjs

[samwgoldman]

mine

[zpao]

👍 we might need to upgrade Babel for this to work, at least the plan I had
was to just run through Babel with only the existing requires pouring we
use for js. But that's not possible right now to run through and only do
that with Babel 5 (at least in the 2 minutes I tried)

On Friday, February 26, 2016, Sam Goldman <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

mine

—
Reply to this email directly or view it on GitHub
#118 (comment).

[samwgoldman]

Thanks—pretty eager to get this fix out. Does a Babel upgrade have any blockers to landing, other than just getting it to work locally?

[zpao]

I think the only thing I'd check is diff the JS files before and after to make sure we don't slip anything in there we don't expect. We have all the plugins ported already. And actually we're just about to do the upgrade for React in facebook/react#6113

[sebmck]

Do we have anything else that uses Babel 5? I want to kill it with fire.

[samwgoldman]

@kittens If you're on a tear and want to take this one, go for it. I think you'll be able to turn it around faster than me. :)

[zpao]

Literally everything else besides React Native still uses 5.

[sebmck]

Like what? React Native, Relay, www, and now React all use Babel 6.

[zpao]

Relay doesn't use Babel 6, nor does flux nor draft. Nothing using
fbjs-scripts did until today (all need the dev plugin you just wrote)

On Friday, February 26, 2016, Sebastian McKenzie [email protected]
wrote:

Like what? React Native, Relay, www, and now React all use Babel 6.

—
Reply to this email directly or view it on GitHub
#118 (comment).

[sebmck]

Thanks for the list, I'll upgrade all of those next week..

On Saturday, 27 February 2016, Paul O’Shannessy [email protected]
wrote:

Relay doesn't use Babel 6, nor does flux nor draft. Nothing using
fbjs-scripts did until today (all need the dev plugin you just wrote)

On Friday, February 26, 2016, Sebastian McKenzie <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

Like what? React Native, Relay, www, and now React all use Babel 6.

—
Reply to this email directly or view it on GitHub
#118 (comment).

—
Reply to this email directly or view it on GitHub
#118 (comment).

Sebastian McKenzie