libfb303_thrift_cpp.so.1.0.0 doesn't have a SONAME about fb303

[yfeldblum]

Would you submit a PR?

@michel-slm

[michel-slm]

So this is intentional - since fb303's API is not stable, leaving the SONAME unset means CMake uses the same value for version and soname. Packagers building shared libraries should make sure to always bump the version.

I'm open to better ideas, or maybe we should just document this better.

[yurivict]

You don't set SONAME at all. You should add the corresponding argument to the link command.

[michel-slm]

see https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html

For shared libraries VERSION and SOVERSION can be used to specify the build version and API version respectively. When building or installing appropriate symlinks are created if the platform supports symlinks and the linker supports so-names. If only one of both is specified the missing is assumed to have the same version number.

Oh, wait, you mean SONAME, not SOVERSION. Where would you suggest it should be set? libfb303_thrift_cpp is eventually generated by this (add_fbthrift_library invokes add_fbthrift_cpp_library)

fb303/build/fbcode_builder/CMake/FBThriftCppLibrary.cmake

Lines 129 to 139 in 9cf1b57

	# Now emit the library rule to compile the sources
	if (BUILD_SHARED_LIBS)
	set(LIB_TYPE SHARED)
	else ()
	set(LIB_TYPE STATIC)
	endif ()
	add_library(
	"${LIB_NAME}" ${LIB_TYPE}
	${generated_sources}
	)