Coder Social home page Coder Social logo

Comments (10)

michaelwclark avatar michaelwclark commented on April 25, 2024 2

I'm going to do a PR hopefully today with the fix. Also in the likely and common event that it takes 6+ weeks to I'll do a fork of this. I don't want to do that, but at this point the whole community is struggling with this issue and we need to keep it moving forward.

from facebook-nodejs-business-sdk.

codytwinton avatar codytwinton commented on April 25, 2024 2

We have merged #73 internally and it should be available on the next release.

from facebook-nodejs-business-sdk.

bertero avatar bertero commented on April 25, 2024 1

Update:
I manually removed the phantomjs-prebuilt and unicode-5.2.0 modules and then normally retrieved and updated campaigns and adSets data.

Something doesn't seem right here guys...

from facebook-nodejs-business-sdk.

yassera2 avatar yassera2 commented on April 25, 2024 1

I'm facing the same issue. Specifically, we're using AWS lambda and the node modules are exceeding the package size limit because of those extra dependencies.

from facebook-nodejs-business-sdk.

mledom avatar mledom commented on April 25, 2024

Agreed, we just ran npm install and noticed phantomJS building downloaded. Its being included from glow-flowtype. I agree with @michaelwclark seems like there are a lot of deps that should be moved to devDep.

from facebook-nodejs-business-sdk.

bertero avatar bertero commented on April 25, 2024

The size of the dependencies is simply huge... I have a 450M project, where more than 300M is only because of facebook-nodejs-business-sdk. Is this really correct?

I don't know if this is the case to open some issue, but it is unavailable for me to keep using it... Does someone know how to make it smaller?

from facebook-nodejs-business-sdk.

mledom avatar mledom commented on April 25, 2024

I'm in the same boat as @yassera2, I'm having trouble deploying to AWS Lambda. I was able to remove the two that @bertero mentioned (thanks!) Seems like there is some optimization that could take place.

from facebook-nodejs-business-sdk.

michaelwclark avatar michaelwclark commented on April 25, 2024

@mledom npm i @denimlabs/facebook-nodejs-business-sdk https://github.com/denimlabs/facebook-nodejs-business-sdk is our active fork. I've been releasing a few times a week so far. Feel free to use that. It reduced our build size signifigantly. Iv'e also added some features and squashed a few bugs. The PR #73
was approved to reduce size, but idk the release schedule with these guys maybe @codytwinton can shed some light on that?

from facebook-nodejs-business-sdk.

stale avatar stale commented on April 25, 2024

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

from facebook-nodejs-business-sdk.

stale avatar stale commented on April 25, 2024

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

from facebook-nodejs-business-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.