Coder Social home page Coder Social logo

Comments (4)

jameshaydon avatar jameshaydon commented on April 20, 2024 1

Hi @stopachka
I'm unsure what sort of change to the rules would achieve this? The rules for plain ordinals are obviously fine, and the rule Time/EN/Rules.ruleTheDOMOrdinal is necessary for parsing things like "the 5th" as a date. Is there some way of ensuring the ordinal parse will achieve a high enough score in order not to be dropped during the ranking phase in the presence of the Time dimension?

from duckling.

stopachka avatar stopachka commented on April 20, 2024 1

Hm, apologies @jameshaydon -- I misunderstood the issue. Will look into it and update you

from duckling.

patapizza avatar patapizza commented on April 20, 2024 1

Hi @jameshaydon, Duckling returns only the top-level tokens, instead of all intermediate matches. As "the 4th" is a valid Time based on an Ordinal, it only returns the top Time token, and not the intermediate Ordinal ("4th"). Also Duckling doesn't use sentence-level features, and there might be false positives like for this example. Depending on your use case, you might need to call Duckling multiple times with different dimensions.

from duckling.

stopachka avatar stopachka commented on April 20, 2024

Indeed seems like a bug. @jameshaydon feel free to take a stab at changing the rules to support this. Otherwise we will take a look shortly

from duckling.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.