Comments (4)
Totally makes sense regarding not wanting to commit to the Provider
design at the moment. Perhaps then it doesn't make sense to document how to implement a Provider
(the design today is also simple enough that a reasonably capable Rust programmer should in theory be able to figure out what's needed with relative ease). So long as the process of adding one stays the same, you could also always point people to this issue and to the draft PR for a GitLab Releases provider to show what's necessary.
There's also the fact that so far the docs for Dotslash appear to be focused on users of it, not contributors to it, so docs on how to write a Provider
would be a little out of place there.
Thanks! Happy to consider this issue resolved for now then.
from dotslash.
(Disclosure: my interest here is that it would be nice to add a GitLab provider which works similarly to the GitHub provider, downloading released artifacts built by CI from a GitLab instance)
from dotslash.
From the current docs:
(At the time of this writing, there is no way to add custom providers without forking DotSlash.)
Relatedly, I don't think that we are ready to commit to the contract of Provider
just yet. To be clear, I am open to considering #3, but it would have to be a built-in provider for now. That way, any changes to the Provider
trait could be made atomically with their implementations.
My only question to validate at the moment is the proper handling of the provider config. It looks like the intent is that the provider config is given as a valid "loosely parsed" JSON value, which the provider itself is then able to deserialize into any specific structure it likes. Do I have that right?
Yes, that is correct.
from dotslash.
@alilleybrinker FYI, I just put up an RFC for this: #7.
from dotslash.
Related Issues (20)
- Consider supporting "tar.xz" format HOT 2
- Homebrew release HOT 3
- Misplaced "format" entry not flagged as error HOT 2
- Feature request: a "check" command that verifies the config for all platforms
- Feedbacks on migrating to full dotslash dev env HOT 1
- Latest release and docs should match HOT 3
- Release status? HOT 4
- Writing a dotslash file for a python toolchain HOT 10
- Fix Homebrew release HOT 2
- Fix CI: macos-13 build appears to be failing HOT 3
- Please don't retag releases HOT 1
- Some tar.gz archives dont decompress correctly
- S3 Provider
- [RFC] configuration file? HOT 3
- Bootstrapping dotslash HOT 2
- Case study: rustc as a dotslash executable, with sysroots
- [RFC] Custom Providers HOT 2
- Support zip in Artifact Format HOT 4
- Add aarch64 to ubuntu release HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotslash.