Coder Social home page Coder Social logo

Comments (4)

alilleybrinker avatar alilleybrinker commented on July 28, 2024 1

Totally makes sense regarding not wanting to commit to the Provider design at the moment. Perhaps then it doesn't make sense to document how to implement a Provider (the design today is also simple enough that a reasonably capable Rust programmer should in theory be able to figure out what's needed with relative ease). So long as the process of adding one stays the same, you could also always point people to this issue and to the draft PR for a GitLab Releases provider to show what's necessary.

There's also the fact that so far the docs for Dotslash appear to be focused on users of it, not contributors to it, so docs on how to write a Provider would be a little out of place there.

Thanks! Happy to consider this issue resolved for now then.

from dotslash.

alilleybrinker avatar alilleybrinker commented on July 28, 2024

(Disclosure: my interest here is that it would be nice to add a GitLab provider which works similarly to the GitHub provider, downloading released artifacts built by CI from a GitLab instance)

from dotslash.

bolinfest avatar bolinfest commented on July 28, 2024

From the current docs:

(At the time of this writing, there is no way to add custom providers without forking DotSlash.)

Relatedly, I don't think that we are ready to commit to the contract of Provider just yet. To be clear, I am open to considering #3, but it would have to be a built-in provider for now. That way, any changes to the Provider trait could be made atomically with their implementations.

My only question to validate at the moment is the proper handling of the provider config. It looks like the intent is that the provider config is given as a valid "loosely parsed" JSON value, which the provider itself is then able to deserialize into any specific structure it likes. Do I have that right?

Yes, that is correct.

from dotslash.

bolinfest avatar bolinfest commented on July 28, 2024

@alilleybrinker FYI, I just put up an RFC for this: #7.

from dotslash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.