Comments (8)
Build error when building cachelib using the provided script build.sh:
./contrib/build.sh -d -j -T -v
Compiler versions:
- cmake: v3.22.2
- gcc/g++: v9.4.0
Error:
CacheLib/cachelib/../cachelib/datatype/FixedSizeArray.h:133:58: warning: returning reference to temporary [-Wreturn-local-addr]
133 | const T& getAt(uint32_t index) const { return elements_[index]; }
| ~~~~~~~~~^
make[2]: *** [datatype/CMakeFiles/datatype-test-FixedSizeArrayTest.dir/build.make:76: datatype/CMakeFiles/datatype-test-FixedSizeArrayTest.dir/tests/FixedSizeArrayTest.cpp.o] Error 1
make[2]: Leaving directory '/CacheLib/build-cachelib'
make[1]: *** [CMakeFiles/Makefile2:3297: datatype/CMakeFiles/datatype-test-FixedSizeArrayTest.dir/all] Error 2
from cachelib.
@therealgymmy When I ran this command ./contrib/build.sh -d -j -T -v
, I got the above mentioned issue. When I commented the below test cases issue is fixed. Causing file line is /cachelib/datatype/FixedSizeArray.h:133
const T& getAt(uint32_t index) const { return elements_[index]; }
Commented test cases.
cachelib/datatype/tests/FixedSizeArrayTest.cpp
//TYPED_TEST(FixedSizeArrayTest, Basic) { this->testBasic(); }
//TYPED_TEST(FixedSizeArrayTest, StdContainers) { this->testStdContainers(); }
//TYPED_TEST(FixedSizeArrayTest, StdAlgorithms) { this->testStdAlgorithms(); }
//TYPED_TEST(FixedSizeArrayTest, testFollyContainers) {
// this->testFollyContainers();
//}
from cachelib.
@sreenivasulureddysura: do you still see this issue? We should have fixed this already.
from cachelib.
@therealgymmy your github action is failing in Ubuntu
for the same issue I was mentioned above. Please take a look at it. Checking my previous comments for fixing the issue.
https://github.com/facebook/CacheLib/runs/7058670118?check_suite_focus=true#step:6:10590
from cachelib.
@sreenivasulureddysura: Yeah you're right. We have not yet landed the fix.
from cachelib.
@sreenivasulureddysura: can you verify if the fix has fixed. We have landed fix for FixedSizeArray on our end (removing the pack attribute).
from cachelib.
This particular issue should be fixed now but centos build is still broken. Will file a separate issue to track
from cachelib.
@therealgymmy Ubuntu issue is fixed. I was able to execute the command without any issues.
./contrib/build.sh -d -j -T -v
from cachelib.
Related Issues (20)
- Enable FDP for CacheBench HOT 29
- qDepth Support for NVM Cache HOT 6
- Questions about trace files when running cachebench HOT 2
- Running simple-cache-example gives an error, flag 'v' was defined more than once HOT 6
- OSS build broken as of May, 2024 -> PRs are all blocked HOT 8
- No build support for Fedora37 OS HOT 4
- failed to build CacheLib following document HOT 2
- Build fails on debian-10 HOT 2
- Segmentation fault while fetching refcount HOT 2
- Minimum Limit For Cache Allocation? HOT 1
- build failed when building dependency 'fbthrift' HOT 3
- Build issue with CacheLib with missing source files HOT 3
- [Seeking Volunteers] Add new builds to CacheLib HOT 2
- Build is failing with error: ‘fmt::v10::detail::type_is_unformattable_for<const facebook::cachelib::navy::Status, char> _’ has incomplete type 1600 | type_is_unformattable_for<T, typename Context::char_type> _; | ^ HOT 4
- NavySetup should not involve the MockDevice HOT 2
- How to configure folly for logging CacheLib
- Build failed with error message "cachelib/navy/common/FdpNvme.h:143:28: error: expected ‘)’ before ‘&’ token 143 | explicit FdpNvme(NvmeData& data, struct nvme_fdp_ruh_status* ruh_status); | ~ ^ | ) make[2]: *** [navy/CMakeFiles/cachelib_navy.dir/build.make:328: navy/CMakeFiles/cachelib_navy.dir/common/Device.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:395: navy/CMakeFiles/cachelib_navy.dir/all] Error 2 make: *** [Makefile:130: all] Error 2 build-package.sh: error: make failed" HOT 4
- Are there instructions on how to build and install in Amazon Linux? HOT 1
- Is nvmLookupLatency just calculates job scheduling time? HOT 1
- Are admission policies applied to objects (value changes in DRAM) even if they are read from the NVM cache? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cachelib.