Coder Social home page Coder Social logo

Comments (6)

stepancheg avatar stepancheg commented on April 28, 2024

Is there a good reason to do it in BXL?

For CI purpose it looks more reasonable to find the files with git, then find file owners with buck2 cquery or something, and then build.

BXL is quite power tool, but it cannot replace everything.

(I think what you ask is not easily possible, but I can be wrong, and this feature could be added to buck2).

Also check https://github.com/facebookincubator/buck2-change-detector project. CC @ndmitchell

from buck2.

cbarrete avatar cbarrete commented on April 28, 2024

It doesn't have to be I suppose, but I figured that getting the right targets to build and/or test afterwards would be easier from BXL.

That link is a 404 for me, but it sounds interesting, is it private?

from buck2.

stepancheg avatar stepancheg commented on April 28, 2024

Sorry, the project is not published yet.

getting the right targets to build and/or test afterwards would be easier from BXL

Also, consider this issue: if build fails, and users want to reproduce it, it would be easier for them if there was buck2 build or buck2 test command in CI logs which users could just copy-paste.

Anyway, BXL cannot do it now easily, but may be able to do it one day if there's demand for it.

from buck2.

cbarrete avatar cbarrete commented on April 28, 2024

Sorry, the project is not published yet.

That's too bad, do you know if there are plans to publish it? More out of curiosity really, I'm going to get this working on our side now either way.

Also, consider this issue: if build fails, and users want to reproduce it, it would be easier for them if there was buck2 build or buck2 test command in CI logs which users could just copy-paste.

That's a good point.

Anyway, BXL cannot do it now easily, but may be able to do it one day if there's demand for it.

Thanks for the clarification!

from buck2.

stepancheg avatar stepancheg commented on April 28, 2024

@cbarrete buck2-change-detector is public now.

from buck2.

cbarrete avatar cbarrete commented on April 28, 2024

Thanks for letting me know!

from buck2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.