Coder Social home page Coder Social logo

Comments (18)

polarblau avatar polarblau commented on May 18, 2024

fabric.js looks really awesome, but not being able to scale or move images in IE7/8 would be pretty much a show stopper for me. Are there any forks or work–arounds existing which tackle this problem? Cheers!

from fabric.js.

kangax avatar kangax commented on May 18, 2024

Not that I know of :(

The problem is that fabric relies on excanvas in non-canvas-capable (but VML-capable) browsers like IE7 or 8.

Last time I looked into this issue, I couldn't figure out why excanvas doesn't render image properly (after rotation)/.

IE9 works as expected, but I understand that IE7/8 support for this could be very crucial.

I'll look into it once again, asap.

from fabric.js.

lukluk avatar lukluk commented on May 18, 2024

awsome

from fabric.js.

fadamakis avatar fadamakis commented on May 18, 2024

Is anyone working on this?
I think this is crucial but I'm kinda lost trying to find the problem.

from fabric.js.

kangax avatar kangax commented on May 18, 2024

IIRC, I ran into excanvas limitation last time I looked at it. Does
excanvas support drawing image with custom transformation?

On Thu, Nov 8, 2012 at 5:59 PM, Fotis Adamakis [email protected]:

Is anyone working on this?
I think this is crucial but I'm kinda lost trying to find the problem.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-10195676.

from fabric.js.

lukluk avatar lukluk commented on May 18, 2024

why we not redirect user to install google chrome frame for IE, iam so stressed , IE very sensitive like a girl haha

from fabric.js.

raichu avatar raichu commented on May 18, 2024

Any developments on this issue?
I checked excanvas, transformations were apparently introduced in r46.

from fabric.js.

raichu avatar raichu commented on May 18, 2024

Just tried it using IE7 and IE8 modes of IE9, transformations worked okay.
Can someone confirm these results with real IE7 and IE8?

from fabric.js.

kangax avatar kangax commented on May 18, 2024

As far as I know, the bug is still in excanvas (you can see a link to it and more in https://github.com/kangax/fabric.js/wiki/Fabric-limitations-in-oldIE)

There's an unofficial patch that supposedly fixes it but I haven't had a chance to try it yet. If anyone can try it and confirm, that would be great!

from fabric.js.

raichu avatar raichu commented on May 18, 2024

Tried the tests in http://dev.sencha.com/playpen/tm/excanvas-patch/, they pass fine on real IE6 (XP).
Unfortunately, the patch is't applied to the upsteam, so maybe fabric.js can maintain it's own version of excanvas.js with the patch applued?

from fabric.js.

kangax avatar kangax commented on May 18, 2024

@raichu Thanks for looking into it. I applied the patch to excanvas.js that we had under /lib. Surprisingly, it applied clean. I then checked in IE8 mode under IE10 (in virtual machine) and while I see that image sizes now seem to be respected (yay!), the position still seems to be defunct. I can move bounding box, but the actual image is always rendered in top/left corner. You should be able to see this on fabricjs.com, which I updated with newly-patched excanvas.

from fabric.js.

raichu avatar raichu commented on May 18, 2024

Wow, I never thought it would be default on fabricjs.com so quickly --thanks!! I just fired up the patterns and controls demos (real IE6, under XP), and everything works just fine. I can move, rotate and scale the image without problems (except I'm getting the wrong mouse cursor when scaling while keeping the aspect-ratio at the corners, but it probably doesn't have anything to do with the canvas). Maybe the IE8 mode isn't really realiable?

from fabric.js.

kangax avatar kangax commented on May 18, 2024

Yeah, IE8 mode could definitely be the problem. I'm glad to hear it's
working for you on IE6. Do you have a way of checking on real 7 and 8?

On Sun, Mar 31, 2013 at 7:01 PM, raichu [email protected] wrote:

Wow, I never thought it would be default on fabricjs.com so quickly
--thanks!! I just fired up the patterns and controls demos (real IE6, under
XP), and everything works just fine. I can move, rotate and scale the image
without problems (except I'm getting the wrong mouse cursor when scaling
while keeping the aspect-ratio at the corners, but it probably doesn't have
anything to do with the canvas). Maybe the IE8 mode isn't really realiable?


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-15694215
.

from fabric.js.

raichu avatar raichu commented on May 18, 2024

Works even better on IE7 (XP): the mouse cursor is the correct one. I'll try to test it on IE8 as well, but I think it'll all be okay.

from fabric.js.

kangax avatar kangax commented on May 18, 2024

Cool. I'm closing this then. If anyone else can confirm, that would be great.

from fabric.js.

kangax avatar kangax commented on May 18, 2024

Now, if we could make other stuff work :)

from fabric.js.

Kienz avatar Kienz commented on May 18, 2024

I tested it on real IE8 (Win 7) and it worked (rotate, move, scale).

from fabric.js.

kangax avatar kangax commented on May 18, 2024

That's great, thanks for confirming @Kienz!

from fabric.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.