Support request for user options to be passed to converter about metamorphosis-nestjs

[fabioformosa]

Ok, interesting.
With reference to both use cases, the converter could be access to the request:

import { REQUEST } from '@nestjs/core';
import { Request } from 'express';

@Convert(Car, CarDto)
@Injectable({ scope: Scope.REQUEST })
export class CarToCarDtoConverter implements Converter<Car, CarDto>{
  constructor(@Inject(REQUEST) private readonly request: Request) {}

 public convert(source: Car): CarDto {
      const target = new CarDto();
      ... HERE THE CONVERSION BEHAVIOUR CAN BE AFFECTED BY THE ACTUAL REQUEST AND REQ PARAMS 
for instance current user, API version, etc...
      return target;
    }
}

What do you think?

[galwa]

I actually thought about this approach, but It would result in implementing whatever logic you wish for both in the interception/controller layer and the convectors - especially in cases were the conversion is not direct request based it wouldn't be helpful,
For example I have an application that communicate with multiple version back-end - in this case the conversion is not request based

[fabioformosa]

Usually the version of the API is in the URL or in a http header. You can get these info from the Request.
Futhermore, I believe it's better using different DTOs if different API versions expose different fields.

Anyway, I've got your point. It's true, class-trasform has recently added some options to the conversion method like versioning or roles. Instead Spring Framework (java) still holds the same signature: Target convert(Source source) and is responsability of the converter to get context data (like current user, request based data) to change the conversion behaviour.

Metamorphosis could adopt to the class-trasform choice with some simple optional params.
Let me think about.