Coder Social home page Coder Social logo

Comments (7)

fabian-hiller avatar fabian-hiller commented on August 15, 2024 1

I am not sure I want to introduce a new syntax just for one case. I recommend going with "Invalid Date" until we find a better solution.

from valibot.

fabian-hiller avatar fabian-hiller commented on August 15, 2024 1

Valibot v0.33.1 is available 🎉

from valibot.

HugeLetters avatar HugeLetters commented on August 15, 2024 1

great, thanks!

from valibot.

fabian-hiller avatar fabian-hiller commented on August 15, 2024

Thanks for bringing this up. We could easily fix this, but we have to be careful not to break the current language-neutral expected and received system, which follows a specific syntax. Instead of English words, we use symbols like ! and <= to describe both properties. Something like InvalidDate makes no sense because there is no InvalidDate data type in JavaScript. Also, Invalid Date does not work because it breaks our syntax. We could change it to !Date to produce an error message that isn't confusing, but that way it's less clear what the error actually is. I would appreciate your feedback on this.

from valibot.

HugeLetters avatar HugeLetters commented on August 15, 2024

Would enclosing "Invalid Date" in quotes work? I've proposed it cause that's the way it's stringified in most environments
image
image

from valibot.

fabian-hiller avatar fabian-hiller commented on August 15, 2024

This is a good idea. The only drawback might be that it is not clear whether the input was the string "Invalid Date" or an invalid date object, but it is probably better than the current solution.

from valibot.

HugeLetters avatar HugeLetters commented on August 15, 2024

We could use quotes which are not used for strings then :)
If string are displayed with " then we might use ` or '

from valibot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.