Build warning when compiled with avr-gcc (GCC) 5.4.0 about printf

[eyalroz]

If you add

should_skip_normalization = true;

within the if (abs_number == 0.0) { block (line 629), does that make the warning go away?

[mickjc750]

No, the warning remains.

The if block at 630-658 will either assign exp10=0, or assign a value to normalization.raw_factor. With exp10==0 the should_skip_normalization boolean will be true, and get_normalized_components() will not be executed.

So the warning is not a real threat. I propose we just add an initializer to the declaration of 'normalization' on line 625.

[mickjc750]

No, that produces an error, should_skip_normalization is undeclared. If I fix that error by declaring should_skip_normalization at the start of the function (instead of line 683), the warning still remains. Do we know if the warning is a real threat? maybe we just init on line 625 in it's declaration? Regards,

…

On Sun, Sep 5, 2021 at 5:41 PM Eyal Rozenberg ***@***.***> wrote: If you add should_skip_normalization = true; within the if (abs_number == 0.0) { block (line 629), does that make the warning go away? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ2OLPCX4DL3DZ6VMODTDTUAMNK5ANCNFSM5C746BRA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- -- Michael Clift - Design Engineer. Clift Innovations Pty Ltd Suit 10/13 Walkers Road Nunawading, VIC 3131 ABN 24 286188328 Tel: [phone] Fax: [phone] Mob: [phone] Email: ***@***.*** Web: www.clift.com.au ***************************************************************************** PRIVATE AND CONFIDENTIAL This e-mail and any files transmitted with it are intended solely for the use of the addressee(s) and may contain information that is confidential or privileged. If you receive this e-mail and you are not the addressee(s), please disregard the contents of the e-mail, delete the e-mail and notify the author immediately. *****************************************************************************

[eyalroz]

Michael, please don't reply with a huge quotation block, that's useless for these bug pages. Just your reply, and nothing else please...

[eyalroz]

Do we know if the warning is a real threat?

We know that it is not. normalization is only used if it is initialized. It's a compiler bug for not noticing this.

maybe we just init on line 625 in it's declaration?

I would rather not initialize normalization, since that implies the initializer values might actually get used, which is not the case. Is AVR-GCC special somehow? Is there a precompiler definition I could use to identify it to special-case it?

[eyalroz]

@mickjc750 : ping.

[eyalroz]

So, this is a compiler bug. The value cannot be used uninitialized. MSVC also fails to realize this.

Closing for now.