Coder Social home page Coder Social logo

Comments (4)

crispen-smith avatar crispen-smith commented on July 30, 2024 3

I agree that this is a sensible solution, but I think that at least speaking to it in docs may be worthwhile. While the Express core team knows this very well I suspect that I'm not the only one who tripped // will trip over this.

from serve-favicon.

dougwilson avatar dougwilson commented on July 30, 2024

So, this module only caters to the favicon case that does not require any HTML markup. The main reason is that all browsers will _unconditionally_make a request for /favicon.ico, unlike the other ones listed above and that /favicon.ico requires a different Content-Type than what a .ico file is served with, making serving favicon.ico unreliable when using a static file server.

For what you listed above, why not just places all those in a directory and use something like serve-static?

from serve-favicon.

dougwilson avatar dougwilson commented on July 30, 2024

It's no problem. If you have anything specific in mind, I'll always gladly take a PR, even doc changes :)

from serve-favicon.

crispen-smith avatar crispen-smith commented on July 30, 2024

Submitted. :)

from serve-favicon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.