Comments (9)
Yea, I was thinking the same thing, that perhaps the stuff in parse should be exported.
/cc @defunctzombie @jonathanong
from cookie-parser.
Sorry about that! My cat stepped on the mouse and closed the issue!
from cookie-parser.
I was going to comment that signedCookies
is intended to be private. If its changed to be reachable, maybe prepend an _
to the name, so people understand that using it outside of this module is not recommended?
from cookie-parser.
@joewagner I think the thing is, we may want it to be public. So in essence, this library will create and set cookies in a certain way and people want to be able to read those cookies without actually straight-up using the middleware to read all cookies. Typically I see people using those functions for websockets, but I don't known enough about websockets to know if they are even doing the correct thing anyway (as far as I know, everyone could just be copy-pasting from everyone else).
from cookie-parser.
@dougwilson That makes sense. I hadn't though about that type of use case for this lib.
from cookie-parser.
I think having a function to parse signed cookies would be ok. Could even be a "method" of the middleware function returned when you create a cookie parser that way you don't need to keep passing in the secret.
from cookie-parser.
Could even be a "method" of the middleware function returned
I like that idea, actually :)
from cookie-parser.
Actually, this library is just to "parse cookies" as a middleware. The generation of the JSON/signed cookies should be a separate module, and this module should simply be a wrapper to use that other module to parse the cookies.
from cookie-parser.
That sounds like a better idea.
On Jun 8, 2014 6:58 PM, "Douglas Christopher Wilson" <
[email protected]> wrote:
Actually, this library is just to "parse cookies" as a middleware. The
generation of the JSON/signed cookies should be a separate module, and this
module should simply be a wrapper to use that other module to parse the
cookies.—
Reply to this email directly or view it on GitHub
#7 (comment)
.
from cookie-parser.
Related Issues (20)
- Cookie Parser not reading signed cookies HOT 2
- Reading duplicated cookies HOT 5
- Docs on signedCookie seem to be off HOT 1
- How to sign a cookie manually? HOT 1
- create and remove cookies HOT 1
- Specific cookie kinda broken HOT 7
- cookieParser.signedCookie seems to not work properly HOT 5
- How to change/set domain, seems impossible? HOT 1
- Cookies values with "j:" prefix should not be parsed as JSON by default HOT 4
- signedCookie is unlikely to be used correctly HOT 1
- How do I clear the cookie(s)? HOT 1
- Inaccurate docs about JSONCookie, JSONCookies, signedCookie and signedCookies HOT 3
- Clear Cookies Feature? HOT 1
- My cookies automatically expire after 30 minutes HOT 1
- Get Metadata from cookie HOT 1
- [ FEATURE ] Support for ES6 imports HOT 1
- Provide types for the cookies in typescript HOT 5
- cookie 0.5.0 HOT 2
- Cookies not setting in production HOT 5
- Node.js v20.9.0 fetch API can't get set-cookie header set by cookie-parser HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cookie-parser.