regression introduced in 1.0.4? about compression

[psq]

I pushed the code with a package.json and an example of a file that hangs (there are others, so it may just be the fact it is quite large)

https://github.com/psq/comp-bug

[dougwilson]

Awesome @psq ! I'm looking into it right now :)

/cc @robbywashere

[psq]

btw, tested with node 0.10.17 and 0.10.28, same result

[dougwilson]

So far I cannot repro on 0.10.28 on Windows :(

[dougwilson]

Chrome 35

[dougwilson]

It is also not reproducing for me on node 0.10.28 on Ubuntu 12.04.4 using Chrome 35. Can you offer a patch or an insight into what is causing the issue?

[steida]

Please revert change and publish it to npm. We can investigate it later.

[psq]

interesting this is only a mac issue then. I'll track down which commit introduced the regression. My guess would be on that one: 5426d13, but I'll double check in a few minutes.

[dougwilson]

@psq just to confirm, when you run a clean clone of what you pushed and run the steps you said, you are able to reproduce the issue on Chrome using Mac? I just want to verify that you did indeed make sure the sample you uploaded reproduced the issue :)

[psq]

@dougwilson yes, I can reproduce the problem with both clone and safari with 1.0.4, and directly using the content of git (see above comment that identifies the commit).

[psq]

Also, same behavior with firefox (29.0.1)

[dougwilson]

Yea, I tried Firefox too on both and it worked fine. I just mentioned Chrome because you said that was where it was broken.

[steida]

OSX Chrome and Safari here.

[dougwilson]

So you serve web site from your Mac OS X laptop? Has anyone been able to reproduce on a non-Mac machine so far?

[psq]

people here develop using macs (but prod server is ubuntu).

[steida]

No, but people can blindly deploy broken app. Not everyone is using robust integration tests.

[psq]

tracing down what is happening, or not happening. once I have enough traces, I'll get a system where it works so I can compare.

[dougwilson]

Seriously guys, can someone debug this on Mac OS X to come up with a patch or an explanation as to what is going on, rather than arguing to revert this? I'm trying to look into it to figure it out, by the arguing is taking all my attention, and it's not easy since I can't reproduce it, either. Please let's do something constructive.

[Svjard]

Same issue, running node 0.10.28 and 0.11.13 running from Debian 6 and 7. I'm working on tracking it down in the code though. Try to get back to you asap.

[dougwilson]

I have just got it to reproduce. I am looking into it right now and should have a working patch very soon.

[dougwilson]

I have a fix and am validating it.

[Svjard]

Awesome thanks.

[dougwilson]

Hi, everyone. Can I have at least one other person verify that the commit c73f1f3 fixes the issue?

[psq]

yes! this fixes this for me on mac with chrome/safari.

FYI, I could also reproduce the issue with xubuntu 13.10 and 14.04. Will double check there as well.

[psq]

also works on xubuntu 14.04 with firefox. Thank you very much for the fix, @dougwilson

[dougwilson]

OK. I'm releasing this as 1.0.5 right now and then having it work up through connect 2/express 3.

[dougwilson]

Can anyone re-try on the now-current master? There was an issue with the patch when requests were not compressed. Just want to confirm instead of rushing something out.

[psq]

sure, will do right now.

[psq]

looks like it works, and chrome shows this in the reply: Content-Encoding:gzip

full headers for request/response:

Remote Address:127.0.0.1:1234
Request URL:http://127.0.0.1:1234/bootstrap.min.css
Request Method:GET
Status Code:200 OK
Request Headersview source
Accept:text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8,fr;q=0.6
Connection:keep-alive
Host:127.0.0.1:1234
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.114 Safari/537.36
Response Headersview source
Accept-Ranges:bytes
Cache-Control:public, max-age=0
Connection:keep-alive
Content-Encoding:gzip
Content-Type:text/css; charset=UTF-8
Date:Wed, 04 Jun 2014 01:06:37 GMT
ETag:W/"988964153"
Last-Modified:Tue, 03 Jun 2014 22:51:07 GMT
Transfer-Encoding:chunked
Vary:Accept-Encoding
X-Powered-By:Express

[steida]

Works for me too.

[dougwilson]

OK, thanks everyone.I was already planning to move this dumb res streaming intercepting into it's own library. Now it's even more complicated :D

[dougwilson]

1.0.5 published to npm.

[psq]

thank you again. Also tested the npm with our full app, works great.

[dougwilson]

OK, everyone, the whole connect 2/express 3 chain has been updated with the fix, if anyone is still using the version of compress that is bundled.

[robbywashere-zz]

It works great on my end. Thanks a lot doug!