Coder Social home page Coder Social logo

Comments (3)

grabbou avatar grabbou commented on June 1, 2024 2

@chirag04 yup, all I am saying is that for me it's just easier to work on the app when the route configuration is in one place (in this case, a file where createRouter is called) instead of being defined in each scene file separately, as in the example demonstrated by you.

If both ways are supported, they should be IMO documented, otherwise it's not clear why they are there :)

from ex-navigation.

chirag04 avatar chirag04 commented on June 1, 2024

@brentvatne actually gave me an example y you would want to use config. I can't find it and not sure y would you use config. If we are to document this I think we should document the usecase also otherwise it would confuse more people.

@grabbou you can have navigationBar with title on the HomeScene.

function HomeScene(props) {
}
HomeScene.route = {
    navigationBar: {
       title: 'Home',
    }
};

from ex-navigation.

brentvatne avatar brentvatne commented on June 1, 2024

I don't like how we're using a private api (makeRoute) here. If this is really important, we should make it possible to pass in component alongside config, where the component passed in gets wrapped by makeRoute internally -- closing this issue but a PR would be welcome!

from ex-navigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.