Comments (6)
k0kubun
commented on June 10, 2024
1
@AS-AlStar Any comments? If you're okay with that change, I'm okay with accepting this change too. But I don't want to maintain server_urls and servers at the same time, so I'd expect the change to remove #30 written by you.
from rspec-openapi.
k0kubun
commented on June 10, 2024
1
merged #61
from rspec-openapi.
AS-AlStar
commented on June 10, 2024
Ok, I'm accept with that changes.
from rspec-openapi.
k0kubun
commented on June 10, 2024
Thank you!
@tashua314 Could you check if this is what you want? #61
from rspec-openapi.
tashua314
commented on June 10, 2024
@k0kubun
Thank you for the fix!
Is it unnecessary to display a message that requires support for those who are using server_urls?
Personally it's perfect!
from rspec-openapi.
k0kubun
commented on June 10, 2024
As it's changing the interface, existing users would see an error message when they upgrade it, and I'm going to imply the breaking change by bumping the minor version under v0.
from rspec-openapi.
Related Issues (20)
- Suggestion for the readOnly property HOT 1
- Getting invalid byte sequence in UTF-8 when the response is a pdf HOT 3
- Difference in Empty Values Handling in Examples HOT 3
- Dealing with responses with different possible bodies for the same status code HOT 1
- requestBody should not merge examples for error HOT 2
- Setting additionalProperties = false HOT 1
- Include property descriptions in response schema? HOT 1
- Regenerating (remove file and run rspec) the schema without changing the code, generates different file. HOT 1
- Authorization HTTP header is inserted as parameter even though there is securityScheme defined HOT 2
- Using `RSpec::OpenAPI.path = ->` but for different audiences HOT 1
- Evaluate proc for RSpec::OpenAPI.title HOT 2
- Manually edited oneOf in response schema is overridden HOT 4
- Hanami framework support HOT 10
- [FEATURE] Create multiple examples for multiple tests for same error code. HOT 5
- preserve comment in openapi yaml HOT 1
- Rails 7.1 transforms request.response_body to Nokogiri class if it is HTML
- Can we remove required parameters for request body? HOT 6
- If parameter has symbol, it will be error HOT 6
- [BUG] NotImplementedError: type detection is not implemented for: :json when ID not found HOT 2
- hanami: non-integer path variable is not supported HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rspec-openapi.