es6 -> commonjs about cryptocompare

[jprichardson]

I don't understand... this module is using commonjs....

[jprichardson]

Have a look... https://github.com/ExodusMovement/cryptocompare/blob/0.1.0/index.js

[jprichardson]

Ah, I'm guessing you're referring to the usage of the enhanced object literals on the exports... this module exists to serve Exodus and if I commit to this small portion, that means I'll tie it to ES5. I can't do that when it's so easy to babelify these things. But it does work just fine in newer Node/commonjs versions (I forgot which version started supporting the new object literal syntax.. v5?) without Babel.

[CraigglesO]

I mean to write es5 commonjs

es6 modules don't work well with webpack/uglify config because as of yet, uglify still can not process new es6 like () => and ${var} strings

[jprichardson]

If you're delivering for Node.js/Electron, you don't need to uglify a 3rd party module. If you're delivering to the browser, you need to browserify/webpack anyways since it has module.exports.

[CraigglesO]

Yes, I am delivering to a browser. My point is, your code does not work with uglify. I am sure I could switch to babili and I wouldn't have issues. But when it bundles everything into one minified js file for production, it errors, because uglify.js does not recognize the es6 code that is used in the index file.

Does that make sense?

I just mean it would be cool if you updated the npm package with something like requirejs
http://renderedtext.com/blog/2013/01/23/compile-requirejs-project-to-single-file/

[CraigglesO]

The easiest way I can think of to simplify the code though (install babel first):
babel index.js > out.js

This makes the file usable for everything.

[jprichardson]

If you're delivering to the browser, you're using Webpack or Browserify, right? If so, drop in a Babel plugin in the pipeline before you Uglify and the problem is solved.