Comments (4)
Turns out there are other more issues to solve.
The Shellwords.escape
method doesn't work as expected either.
The best way I found was to put each file within "A filename with spaces.jpg"
.
That has to be followed by a change from join(' ')
to join('" "')
and additional quotes around the list of filenames in the cmd varialble.
The output of the exiftool on Windows doesn't match what's in the expected
folder. Therefore the tests aren't green.
I hoped I could send a merge request, but it's too early.
it's messy :-(.
Do you have routine to turn the output of exiftool into yaml format for the expect files?
from exiftool.rb.
@sroller thanks for digging into it. I haven't touched the code for this gem in a while, with exception of the minor housekeeping tasks. I will try to find some time to look into exiftool output -> yaml question and get back to you. Please keep me posted on developments on your side of things and I'm happy to discuss potential changes.
from exiftool.rb.
I believe that additional output key/value pairs that you may see on Windows can be added to keys to be ignored during tests in exiftool_test.rb
line 9
There is also another spot where we use /dev/null
and it would need to be based on OS used.
And last issue is related to spaces in paths/filenames as you've mentioned - that's a little messy.
from exiftool.rb.
I'm the original author of this gem (I stopped using ruby more than a decade ago).
Kudos to @morozgrafix for keeping it alive! 💪
Windows filename support will at least require shenanigans like this: https://github.com/photostructure/exiftool-vendored.js/blob/main/src/FilenameCharsetArgs.ts
(I had to add a bunch of example filenames with different unicode block classes, and add windows to my GHA test matrix, and even then, there are issues with some multi-character emoji in filenames).
from exiftool.rb.
Related Issues (13)
- Some files can break the module. HOT 2
- seems to be an error on line 21 of exiftool.rb HOT 2
- unknown "Pathname" HOT 4
- Getting an invalid date error when extracting metadata for certain files HOT 16
- ExiftoolNotInstalled error when trying to remove EXIF data HOT 1
- remove Travis CI builds
- Tests are broken when minitest 5.19 is used
- EXIF fields with non-Roman characters HOT 6
- Compatibility Inquiry: Exiftool 1.2.4 or 1.2.3 with Ruby 3.3.0 HOT 3
- Mutliget returns nil HOT 4
- using the '-n' option for an image with gps coordinates gives warnings HOT 1
- using a Pathname as file argument results in error. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exiftool.rb.