Linking fails on Fedora 22 about imv

[jdiez17]

FreeImage_EnlargeCanvas was added in version 3.13.0, so you need to upgrade freeimage. We use it to composite some types of gifs, so it's not a feature we can do without. Perhaps it would be a good idea to provide our own EnlargeCanvas function. Thoughts, @eXeC64?

[eXeC64]

I didn't realise it was such a recent feature. Given that F22 was only released in May I think we should be supporting it. We'll just have to re-implement it.

[sjkingo]

According to the release announcement for 3.13.0, FreeImage_AllocateEx was added in this version also, along with FreeImage_EnlargeCanvas, so the build still does not work against Fedora 22's freeimage-3.10:

build/image.o: In function `imv_image_load_next_frame':
image.c:(.text+0x581): undefined reference to `FreeImage_AllocateEx'
collect2: error: ld returned 1 exit status

I will see what version of freeimage is in the F23 repos and report back: perhaps you could just pin the minimum version of freeimage to 3.13.0 if it's in the newer repo.

[eXeC64]

Good grief. FreeImage v3.13.0 has been out for 6 years already, and Fedora 22 is shipping an older version than that? Seems that v3.10.0 was released in 2007, making it 8 years old.

I'm not holding out much hope for Fedora 23's repositories.

[eXeC64]

@sjkingo I've just pushed a commit that replaces AllocateEx with Allocate. If Fedora 22 doesn't have that I'll eat my hat.

[sjkingo]

No hat eating required @eXeC64: that works nicely, thank-you.

For reference, F23's main repo has version 3.17.0 of freeimage and freeimage-devel. Looks like the maintainer updated it only recently.

Appreciate the quick fixes!

[eXeC64]

Good to hear. 🍺