Consider new name or alias for 'call' about batch-loader

[exAspArk]

Thank you for opening the issue!

call is pretty generic

Yes, I agree. On the other hand, match_id is too specific and assumes that the first argument is some kind of ID, which not always the case.

In general, loader is just a "function" (lambda). That is why it is executed by using the standard Ruby load method. Renaming it will require changing the data structure. And at the same time, I'd like to avoid making breaking changes, so we'd need to keep the compatibility with load. But if you come up with some better names, feel free to share :)

[davidw]

How about...

• lookup.call
• matcher.call
• connector.call

I could also imagine something fancier like set_target(target).from(source) although I don't know how you'd get that working, not knowing the internals of all this!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[davidw]

Still interested.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[davidw]

Still interested

[exAspArk]

Thanks for your feedback!

• lookup.call
• matcher.call
• connector.call

I think you can easily use any of the suggested names in your code since loader is just the name of a local variable with a lambda:

BatchLoader::GraphQL.for_id(post.user_id).batch do |user_ids, connector|
  User.where(id: user_ids).each { |user| connector.load(user.id, user) }
end

I wouldn't go with anything fancier to keep it simple for now since it will require creating a more complicated loader object vs simple lambda. Maybe in the future :)

I am going to close the issue.