Comments (1)
Hello @MarleneKress79789 I tested both changes successfully.
Test strategy change I (remove option --fix
):
- I checked out the branch of the PTB corresponding to the current ticket
- in the working copy of my repo I called
poetry add ..\python-toolbox
- I called
poetry run version-check github_issue_adapter/version.py
without-f
and did not observe an error - I called
poetry run version-check -f github_issue_adapter/version.py
and did not observe an error, either
Test strategy change II (add optino --no-ansi
):
- I called
poetry run python -m exasol.toolbox.pre_commit_hooks.package_version github_issue_adapter\version.py
and did not observe any error, anymore.
Strangely removing the option --no-ansi
in my virtual poetry env did not show any error, either. But the change probably still improves the stability and does not cause additional problems on windows, either.
So from my perspective I can safely approve the changes based on my review results.
from python-toolbox.
Related Issues (20)
- 🐞 Vulnerability issue creator fails when Maven report does not contain "vulnerable" entry
- ✨ Support template-base changelog maintenance HOT 1
- ✨ Vulnerability issue creator must add issues to configurable project
- 🔧 Change metrics format so the repo/project is part of the reported metric
- Test: Issue with associated project
- Test: Issue with associated project
- Test: Issue with associated project
- Test: Issue with associated project
- ✨ Security issues creator outputs information about created issues
- ✨ Add standard `nox task(s)` for preparing a release HOT 2
- 🔧 Fix linting issues to improve overall project score
- 🔧 Refactor issue and workflow command
- ✨ Add standard `nox task(s)` for creating a release
- ✨ Add support for automatically updating workflow templates to `prepare-release`
- ✨ Add support for `import-linter` to `lint` tasks
- ✨ Add support for project license auditing HOT 1
- ✨ Add support for dependencies.md like output
- 📚 Small documentation issues HOT 1
- 🐞 Fix build scripts HOT 1
- ✨ Support creating tickets for vulnerabilities in Go projects
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-toolbox.