Coder Social home page Coder Social logo

🐞 Version check issues about python-toolbox HOT 1 CLOSED

exasol avatar exasol commented on August 19, 2024
🐞 Version check issues

from python-toolbox.

Comments (1)

ckunki avatar ckunki commented on August 19, 2024

Hello @MarleneKress79789 I tested both changes successfully.

Test strategy change I (remove option --fix):

  • I checked out the branch of the PTB corresponding to the current ticket
  • in the working copy of my repo I called poetry add ..\python-toolbox
  • I called poetry run version-check github_issue_adapter/version.py without -f and did not observe an error
  • I called poetry run version-check -f github_issue_adapter/version.py and did not observe an error, either

Test strategy change II (add optino --no-ansi):

  • I called poetry run python -m exasol.toolbox.pre_commit_hooks.package_version github_issue_adapter\version.py and did not observe any error, anymore.

Strangely removing the option --no-ansi in my virtual poetry env did not show any error, either. But the change probably still improves the stability and does not cause additional problems on windows, either.

So from my perspective I can safely approve the changes based on my review results.

from python-toolbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.