Unit tests for profile module are failing about psick

[snesbittsea]

Basic problem appears to be that profile::hosts::file expects to be set $::profile::settings::primary_ip and not be undef. But there is no guarantee that the profile::settings class is processed.

[alvagante]

Actually profile::settings should be included in manifest/site.pp as a prerequisite.

[snesbittsea]

Hmm...

Ok, a couple of issues here. First, the fixtures/manifests/site.pp is out-of-date and doesn't match the site/manifests/site.pp

Second, there is a bug (rodjek/rspec-puppet#322) in rspec-puppet that under puppet 4.x prevents site.pp from being processed. It does look like a fix has been merged in, but obviously my version of rspec-puppet doesn't contain the fix.

I modified the profile Gem file to pick up the latest rspec-puppet from github and if the existing fixtures/manifests/site.pp is replaced by the manifests/site.pp good things happen.

I'm thinking that the best solution to #2 is to symlink in the canonical site.pp into the fixtures/manifests directory using the .fixtures.yml. That way you don't have to maintain two identical copies of site.pp.

Also, part of what I am working on is updating the profile Gemfile to bring it more inline with what I understand are best practices/standards. I'll have a pull request for you - if you want it - in a week or so.

[snesbittsea]

Damn - didn't mean to close it :-)

[tuxmea]

@snesbittsea we had a PR a couple of days ago bringing acceptance tests. There is now one PR open bringing host tests. Does this solve this issue?

[tuxmea]

@snesbittsea can you please check whether this issue is still open when using latest development or production branch?

[alvagante]

All tests ok now