Comments (5)
I'll implement this in multiple steps:
- Move
MeasureDuration
to cats-helper: done in evolution-gaming/cats-helper#213 and evolution-gaming/cats-helper#214. Versions 3.5.0 and 2.11.0 released. Adding the missing test in evolution-gaming/cats-helper#215 and evolution-gaming/cats-helper#216 - Introduce
KafkaMetricsCollector
toskafka
; release a new minor version: done in #340 and #339. Versions 15.1.0 and 11.15.0 released - Update
smetrics
: evolution-gaming/smetrics#250 and evolution-gaming/smetrics#251- bump
cats-helper
version - use the new
MeasureDuration
fromcats-helper
- drop
KafkaMetricsCollector
- remove
skafka
dependency - release a new major version
- bump
from skafka.
let's move MeasureDuration
to cats-helper
from skafka.
let's move MeasureDuration to cats-helper
That's a good call. However, it won't solve the issue as there'll still be usage of com.evolutiongaming.smetrics.{CollectorRegistry, LabelNames, Quantiles}
in ProducerMetrics
and ConsumerMetrics
. And, in turn, those are part of method signatures in ConsumerOf
/Consumer
/ProducerOf
/Producer
: ConsumerOps.withMetrics1, ConsumerOf.apply, Producer.apply, ProducerOps.withMetrics, ProducerOf.apply.
from skafka.
for those parts I'd suggest to move KafkaMetricsCollector
module to skafka
project
from skafka.
Resolved, corresponding releases:
smetrics:
- https://github.com/evolution-gaming/smetrics/releases/tag/v2.0.0
- https://github.com/evolution-gaming/smetrics/releases/tag/v0.5.0
skafka:
- https://github.com/evolution-gaming/skafka/releases/tag/v15.1.0
- https://github.com/evolution-gaming/skafka/releases/tag/v11.15.0
cats-helper:
- https://github.com/evolution-gaming/cats-helper/releases/tag/v3.5.0
- https://github.com/evolution-gaming/cats-helper/releases/tag/v2.11.0
from skafka.
Related Issues (20)
- consumer.offsetsForTimes - consider using Instant as query types instead of Offset
- add metrics for subscribe with RebalanceListener1
- [Discussion] Derive ToTry timeout based on ConsumerConfig.maxPollInterval
- Document ToTry timeout importance in README
- add logging for subscribe with RebalanceListener1
- Support error handling in RebalanceCallback
- Extract FiberWithBlockingCancel to cats-helper
- Potential StackOverflowError in mapK of RebalanceCallback HOT 1
- Improve documentation HOT 2
- Remove Kafka SASL configuration warnings
- Definition of client.rack at CommonConfig level causes kafka ProducerConfig to complain HOT 1
- Kafka has `KafkaProducer#metrics` - why skafka doesn't expose those metrics?
- in `1.1.0`, the metrics are not shared
- Incompatible with kafka-clients 3.7.0 due to usage of NoOpConsumerRebalanceListener
- Add sbt-version-policy
- Please provide a way to send "tombstone" message HOT 1
- Improve configuration for producer and consumer regarding bytes HOT 1
- Review producer API HOT 4
- Consumer.poll metrics do not work in case of assign/seek flow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skafka.