Coder Social home page Coder Social logo

Implement stacktrace for errors about ethermint HOT 4 CLOSED

evmos avatar evmos commented on June 15, 2024 1
Implement stacktrace for errors

from ethermint.

Comments (4)

fedekunze avatar fedekunze commented on June 15, 2024 1

Action Items (correct me if I'm wrong @khoslaventures):

  • Replace fmt.Errorf with stacktrace.NewError or stacktrace.NewErrorWithCode (in case the code is available/defined like the ones on errors.go)
  • Wrap all returned errors with stacktrace.Propagate or stacktrace.PropagateWithCode (in case the code is available/defined like the ones on errors.go)

Ref: https://pkg.go.dev/github.com/palantir/stacktrace

from ethermint.

khoslaventures avatar khoslaventures commented on June 15, 2024 1

Yep, exactly. We may need to revisit how the errors propagate up and get sent to the logger as well.

from ethermint.

liamsi avatar liamsi commented on June 15, 2024

Don't mean to distract you guys but just out of curiosity: were there any particular reasons to use palantir's lib instead of this one for instance https://github.com/go-errors/errors

Ah NVM, found the answer in the palantir docs I guess:

The intent is not that we capture the exact state of the stack when an error happens, including every function call. For a library that does that, see github.com/go-errors/errors.

from ethermint.

fedekunze avatar fedekunze commented on June 15, 2024

implemented

from ethermint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.