Proposal: design change corp pages | Unicode problems about seat

[leonjza]

Thanks.
As for the encoding weirdness, its partly due to the fairly aggressive escaping that it goes through in this function.

As for the industry progress bars etc, this is something that can easily be added again. I just don't have API keys that can give me detailed info to actually test with.

[Xaroth]

I would have no issue with sharing some keys that are actively used if you need that to test.

I'll have a look at that function and see if I can suggest some changes to make this work better.

[Drynael]

I can provide you also some keys on corp or pilot base.

[leonjza]

Cool. I'll poke this thread again when I am ready.

[Xaroth]

As for the unicode parts, some quick looking shows that DOMDocument will not treat the html content as unicode unless explicitely specified.

One option would be to wrap it in wrapper html and set a meta tag to specify the content to be unicode, or use mb_convert_encoding to convert all non-ascii stuff from UTF-8 with html entities.

On that note, I also see that color and size props are stripped out, while I understand that part (plus, ccp's font color spec is not rgb, it's argb). While I agree with the implications of having that, an argument could be made that font colour is not really a security issue, and could be a configurable option whether or not to strip out.

[leonjza]

Could something like this work to normalize those chars?

[Xaroth]

Not really, the data itself is actually unicode data (2 bytes per character), but it is forced downwards to ascii (1 byte per character), so the data you see is not the data the API returns.

the parser that is being used needs to be made aware that the data it is extracting should be unicode data, or convert the unicode data to ascii with html entities using mb_convert_encoding... after that it -should- work just fine.

For reference, the API output: https://api.eveonline.com/corp/CorporationSheet.xml.aspx?corporationID=98387826

[leonjza]

Ah, excellent, thanks for the example.

[leonjza]

Unicode problems should be gone with eveseat/services 1.0.14.

Going to hold off with the corp page designs for now.