Coder Social home page Coder Social logo

Comments (5)

davewhiteland avatar davewhiteland commented on August 19, 2024

Slightly more in line with our existing naming (there's no consistent policy, which is fine), probably better to say what it is rather than what it does:

  • data_pr_change_summarizer

pr isn't great in there, but on the other hand, it's not that obscure in the context of what it's doing. Take it out and the repo is making grander claims than it executes; expand it to pull_request (or even pull-request) and the repo name has become Llanfairpwllgwyngyllgogerychwyrndrobwyllllantysiliogogogoch.

Ending with ize is fine and, because of the tendency of tech keywords to adopt US spelling (hello color), it's something English-speaking nerds simply have to get used to. Embrace ize. Like we did in the 15th century already.

from data_pr_change_summarizer.

davewhiteland avatar davewhiteland commented on August 19, 2024

Do we have a preference on hyphens vs. underscores in repo names? I think it's because you're adhering to useful behaviour for Gems for the underscores, but I notice it's otherwise hyphens on the key repos I'd called out in https://github.com/everypolitician/everypolitician's README.

from data_pr_change_summarizer.

chrismytton avatar chrismytton commented on August 19, 2024

I don't think we've got an explicit preference (yet) but I tend to try and stick to the guidelines for gem naming. They basically say use underscores unless it's an extension to another library (e.g. jekyll-everypolitician).

So I would say that viewer-sinatra and webhook-manager are probably not such great names, but everypolitician-popolo and jekyll-everypolitician are OK because they sit under the everypolitician and jekyll namespaces.

from data_pr_change_summarizer.

chrismytton avatar chrismytton commented on August 19, 2024

Done!

  • Rename on GitHub
  • Update Travis
  • Update any mentions of the old name in the README
  • Re-connect with the repository on Heroku
  • Rename the Heroku app
  • Re-connect Heroku to GitHub for auto-deploys
  • Update the webhook url on webhook manager

from data_pr_change_summarizer.

davewhiteland avatar davewhiteland commented on August 19, 2024

from data_pr_change_summarizer.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.