Comments (13)
@evereq I have changed notifications for all modules. I have used ToastrService
for all module. Please review it and give me your valuable feedback.
from ever-gauzy.
@rahul-rathore-576 okay, I will remove async
from danger method.
from ever-gauzy.
@boyanstanchev did you add loading indicator to all pages? What about employees management page (http://localhost:4200/#/pages/employees)?
from ever-gauzy.
@AlexTasev please check every page and add loading indicators & toast notifications, same as we already did on many pages.
Note: toast notifications should always show context, e.g. record which was added/removed/ changed like "Organization 'Yo Technologies' was removed", etc.
from ever-gauzy.
@evereq I have changed notifications for organization module and I have few questions for notification message, Right now in some modules showing success message like attached image(1) and some module showing message like image(2). so can you please confirm which message notification toast we need to add for whole app.
from ever-gauzy.
@parmarchirag93 how it is different in the code, I see we are using our own "toastrService" in some places? We not using it in other places? What we use there? Best if you can send links to both such places in code, so I review and decide which one we should use everywhere.
from ever-gauzy.
Yes, we are using NbToastrService
for toaster message and below is files there are using different toaster messages.
For image(1) => gauzy\apps\gauzy\src\app@shared\project-select\project\project.component.ts
For image(2) => gauzy\apps\gauzy\src\app@shared\expenses\recurring-expense-mutation\recurring-expense-mutation.component.ts
from ever-gauzy.
@parmarchirag93 let's use everywhere our own toastrService, i.e. "image(1)" and code like
this.toastrService.success(
'NOTES.ORGANIZATIONS.EDIT_ORGANIZATIONS_PROJECTS.ADD_PROJECT',
null,
{ name }
);
It's better because it wraps translation inside, so we do NOT need to do it every time like:
this.toastrService.primary(
this.getTranslation(
'NOTES.ORGANIZATIONS.EDIT_ORGANIZATIONS_EXPENSE_CATEGORIES.ADD_EXPENSE_CATEGORY',
{
name: name
}
),
this.getTranslation('TOASTR.TITLE.SUCCESS')
);
So I think instead of above, we will need to just make it like:
this.toastrService.success(
'NOTES.ORGANIZATIONS.EDIT_ORGANIZATIONS_EXPENSE_CATEGORIES.ADD_EXPENSE_CATEGORY',
null,
{ name }
);
from ever-gauzy.
@parmarchirag93 btw, I changed the implementation of the service itself to use "this.nbToastrService.primary" as I like blue color more than green for notifications (more consistent with Gauzy colors) - /gauzy/src/app/@core/services/toastr.service.ts#L23
Also, as part of this task, can you please verify why we have one method (danger
) defined with async
, while the other 2 methods without? https://github.com/ever-co/gauzy/blob/develop/apps/gauzy/src/app/@core/services/toastr.service.ts#L29
@rahul-rathore-576 if you have ideas, let us know. I think it should be all async
or should all be without async
. What do you think?
from ever-gauzy.
via Hubstaff
User: Chirag Parmar
Project: Gauzy Platform - https://app.hubstaff.com/projects/681079
Date Range: 12/22/20 - 12/22/20
Work session total: 3:39:28
Billable: No
Grand total: 3:39:28
from ever-gauzy.
@parmarchirag93 btw, I changed the implementation of the service itself to use "this.nbToastrService.primary" as I like blue color more than green for notifications (more consistent with Gauzy colors) - /gauzy/src/app/@core/services/toastr.service.ts#L23
Also, as part of this task, can you please verify why we have one method (
danger
) defined withasync
, while the other 2 methods without? https://github.com/ever-co/gauzy/blob/develop/apps/gauzy/src/app/@core/services/toastr.service.ts#L29
@rahul-rathore-576 if you have ideas, let us know. I think it should be allasync
or should all be withoutasync
. What do you think?
@evereq There is no need async
in danger method. So we can remove it. @parmarchirag93
from ever-gauzy.
via Hubstaff
User: Chirag Parmar
Project: Gauzy Platform - https://app.hubstaff.com/projects/681079
Date Range: 12/23/20 - 12/23/20
Work session total: 3:45:52
Billable: No
Grand total: 7:25:20
from ever-gauzy.
@parmarchirag93 amazing work, thank you!
from ever-gauzy.
Related Issues (20)
- [Fix] Generated invoice item have NaN value of Total Value
- [Feat] Add Filter input to search roles & permission lists
- [Bug] Broken queries
- [Fix] Style Roles & permissions list
- [Fix] Hide Time Off buttons if Employee doesn't have permission
- [Feat] Add a loading indicator in Desktop Timer Tasks list section
- [Feat] Add (X) button in Screenshot popup notification
- [Question] Installing gauzy server on AWS EC2 Ubuntu HOT 16
- [Fix] Auth login flow
- [Feat] Mini Timer Window remembers its last position on launching app
- [Bug] Unable to follow local build / run instructions - build failing HOT 3
- [Feature] Support DigitalOcean Spaces storage with CDN
- [Chore] NodeJs update compatibility with `ffi-napi`
- [DevOps] Need support for windows 7 HOT 3
- [Feature] Use build-in Caching in TypeORM / MikroORM in some queries
- [Bug] Unable to start Gauzy Server on Ubuntu Linux HOT 4
- [Bug] Persistent User Session Across Uninstallations of Desktop Timer on Ubuntu 22.04.4 LTS (NO USER DATA)
- [Bug] Auto-Login Issue After Reinstalling Desktop Timer
- [Feature] Sync Project, Team, Task and other details between timers running on different devices
- docker compose files aren't valid HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ever-gauzy.