Associate Emails not working about eventum

[glensc]

can you give example urls of each errors. i do not know how all Eventum functionality can be accessed, ot screenshots?

[m39yur1p7]

The first two notices are the result of a HTML-escaped but still interpreted code in templates/associate.tpl.html lines 57-68. If validateForm() returns always "true" then it disappears but a proper resolution is still needed.

The main problem seems to be rooted in associate.tpl.html line 74-75:

    <input type="hidden" name="cat" value="associate">
    <input type="hidden" name="issue_id" value="{$smarty.get.issue_id}">
    {section name="i" loop=$emails}
    <input type="hidden" name="item[]" value="{$emails[i]}">
    {/section}
    <table class="bordered medium left">

This code doesn't output the list of email(s) passed in item[] to associate.php in the url:

https://eventum.xxx.hu/associate.php?cat=associate&item%5B%5D=19479&issue=existing&issue_id=7813&page_size=50&hide_associated=on

so the form is created without the list of items to be associated.

<form name="associate_email_form" method="post" action="associate.php" onSubmit="return validateForm(this);">
    <input type="hidden" name="cat" value="associate">
    <input type="hidden" name="issue_id" value="7813">
*** This is where the item list is missing ***
        <table class="bordered medium left">

On submission item[] is not set and following processing fails because of its NULL value.

[m39yur1p7]

bugfix:

    <input type="hidden" name="cat" value="associate">
    <input type="hidden" name="issue_id" value="{$smarty.get.issue_id}">
    {section name="i" loop=$smarty.get.item}
    <input type="hidden" name="item[]" value="{$smarty.get.item[i]}">
    {/section}
    <table class="bordered medium left">

[glensc]

It would be a log more easier to chef if the "bugfix" is in "diff" form, or even better Pull-Request. here i can't see what is needed to make the change (what line to add, what line to remove, what line to modify)

[m39yur1p7]

I can do diff:

--- associate.tpl.html  2016-06-20 16:27:06.281626150 +0200
+++ associate.tpl.html.bug173.fixed     2016-06-20 16:27:06.281626150 +0200
@@ -71,8 +71,8 @@
 <form name="associate_email_form" method="post" action="associate.php" onSubmit="return validateForm(this);">
     <input type="hidden" name="cat" value="associate">
     <input type="hidden" name="issue_id" value="{$smarty.get.issue_id}">
-    {section name="i" loop=$emails}
-    <input type="hidden" name="item[]" value="{$emails[i]}">
+    {section name="i" loop=$smarty.get.item}
+    <input type="hidden" name="item[]" value="{$smarty.get.item[i]}">
     {/section}
     <table class="bordered medium left">
         <tr class="title">

I'd appreciate a beginners' guide to pull-requests and other functions of github if there is such...

[glensc]

https://www.google.ee/search?q=github+pull+requests

[glensc]

also, diff -u is more readable