Workflow: shouldAutoAddToNotificationList: Return false about eventum

[glensc]

always use git tag when linking to line of code, not master.
as "master" branch is moving target, the line may not match at the time i go and try to look at it.

i've corrected this issue now myself.

[glensc]

is the $issue_id empty in your condition? as there seems to be a slight logic change:

old code:

        // only send a direct email if the user doesn't want to add the Cc'ed people to the notification list
        if ($add_unknown || Workflow::shouldAutoAddToNotificationList($prj_id)) {
            if ($issue_id) {
                        // add the recipients to the notification list of the associated issue
            }
        } else {
        }

new code:

        // only send a direct email if the user doesn't want to add the Cc'ed people to the notification list
        if (($add_unknown || Workflow::shouldAutoAddToNotificationList($prj_id)) && $issue_id) {
            // add the recipients to the notification list of the associated issue
        } else {
        }

i wonder, is that the case, or is the problem that value of $add_unknown is incorrect.

[poing]

The issue is created by mail, Auto-Creation of Issues = Enabled

So $issue_id shouldn't be empty.

[glensc]

can you git bisect to exact commit that breaks it?

[poing]

@glensc seems I misinterpreted the symptom to the cause. Workflow shouldAutoAddToNotificationList does NOT seem to work in 2.3.6 either.

The symptom I was chasing down, external users would receive BOTH Issue Created && New Issue notifications. New Issue notifications should only be sent to Eventum Users. I thought, this was caused because the user being added to the notification list.

So I tried to remove the user from the notification list, without success. It's still a bug in the workflow, but I'm not sure when it was working (or where it broke).

[glensc]

i think @balsdorf found the same bug when he worked on #123 testing.

[balsdorf]

@glensc The bug I found was relating to the ambiguity of the UI when sending emails. I don't believe this is the root cause of this (#113) though.

@poing I'm trying to track down the cause of this. Can you share screenshots of your mail queue and notification list please?

[balsdorf]

@poing No need for those screenshots, I've tracked it down.

#124 Fixes this by not sending the new issue email to the sender of the original email. Please reopen this if this doesn't solve the problem for you