All stream subscriptions have errors with filters about eventstore-client-nodejs

[George-Payne]

Hi Matthew,

Thanks for the issue and reproduction. Looks like filters are currently a big hole in test cases / doc comments.

In your example:

    const sub = client.subscribeToAll({
      filter: { filterOn: STREAM_NAME, regex: `^${stream}$` },
      fromPosition: START,
    })

When this is sent over GRPC you get:

streamIdentifier: { regex: '^my_stream$', prefixList: [] },
eventType: undefined,
max: 0,
count: undefined,
checkpointintervalmultiplier: 0

but max and checkpointintervalmultiplier both have to be non-zero. (GRPC defaults numbers to 0 when not specified).

So for the time being you can work around it by changing to:

    const sub = client.subscribeToAll({
      filter: { filterOn: STREAM_NAME, regex: `^${stream}$`, max: 32, checkpointintervalmul: 1 },
      fromPosition: START,
    })

In #127 I've reworked the code around this. The helper functions streamNameFilter and eventTypeFilter now provide sensible defaults and if you pass 0, it will throw an error before its sent to the server.

I've also opened an issue EventStore/EventStore#2790 to improve the error message from the server.