Package requires @types/google-protobuf as prod dependency but declares as a dev dependency about eventstore-client-nodejs

[YoEight]

I fail to see your point. Those files aren't publicly exposed to the user.

[LucasPaganini]

The types are exposed. You can't compile your typescript code if it uses this package without having @types/google-protobuf installed.

mkdir test
cd test 
npm init -y
npm i @eventstore/db-client
npm i -D typescript

tsconfig.json

{
  "compilerOptions": {
    "alwaysStrict": true,
    "noImplicitAny": true,
    "noImplicitReturns": true,
    "strictNullChecks": true,
    "module": "system",
    "moduleResolution": "node",
    "sourceMap": true,
    "declaration": true,
    "target": "es2018",
    "lib": ["es2020"],
    "baseUrl": ".",
    "outDir": "dist",
    "allowJs": false,
    "types": ["node"]
  },
  "include": ["src/**/*"],
  "exclude": ["node_modules", "src/**/*.spec.ts"]
}

src/main.ts

import { EventStoreDBClient } from "@eventstore/db-client";

const EVENTS_HOST = "localhost:2113";
const EVENTS_STREAM = "app-events";

(async () => {
  const eventStoreClient = new EventStoreDBClient(
    { endpoint: EVENTS_HOST },
    { insecure: true }
  );

  const sub = eventStoreClient.subscribeToStream(EVENTS_STREAM);
  sub.on("data", (resolvedEvent) => {
    console.log("Event", resolvedEvent);
  });
})();

Can't compile

Try npx tsc, you'll see 6 erros because the package is exporting types from @types/google-protobuf that are not present in the dependencies.

Now npm i -D @types/google-protobuf and try to compile npx tsc. Now it works.