Comments (4)
I was aware there were semantic attribute names, but not span names. I agree that it is good to follow specs as much as possible, but as we do not have any route
information, the span name would just be the method?
We could have an optional config parameter to get route information I guess?
Love to hear your thoughts (and your colleague/friend/other person who reviewed it)
from otel-cf-workers.
Also..I forgot to mention there is the updateName
method on a span that would update the name, so it wouldn't require an entire postProcessor
setup just to change the name.
from otel-cf-workers.
Going to close this for now, as it is easy to update the name at the moment. Let me know if you have strong feelings about doing this in the library, but having just a bunch of 'GET' as the name of all top level spans might be a bit too confusing?
from otel-cf-workers.
The span naming is something I noticed as well. span.updateName
is a great suggestion for this 👍🏻 I've been using Hono and will probably be updating the span name to incorporate the route pattern rather than the incoming request path. I haven't put all that together yet though, so we'll see if it works out 😄
I don't fully agree with the OpenTelemetry conventions on this (I also find it confusing and non-descriptive), but I'd prefer following it anyway for consistency when adopting the package. I'm not strongly opinionated on it though and will likely be modifying the span names regardless; just sharing my thoughts 🙂
from otel-cf-workers.
Related Issues (20)
- Pages function support HOT 3
- Browser Rendering API Breaks When Instrumenting HOT 5
- The global tracer is not of type WorkerTracer and can not export spans HOT 3
- getActiveConfig() returns null HOT 8
- [Question] Does this also intercept logs and send it? HOT 1
- cache.hit attribute is the opposite
- feature request: export const unwrappedFetch = unwrap(fetch)
- [Question] Support for sending traces to other tracing backends/vendors? HOT 4
- [feature request/question] support without node dependencies HOT 4
- [feature request]: Support for Cloudflare Pages HOT 7
- getTracer + startActiveSpan not working due to missing global patch HOT 2
- Errors importing module HOT 1
- Accurate timings when instrumenting code that doesn't do network IO HOT 5
- [Bug] `trace.getActiveSpan()` returns undefined, regression HOT 5
- Instrumentation breaks new RPC style service calls HOT 12
- RFC: Removing CommonJS support
- Question: Ignore certain hosts or api calls with a header HOT 1
- [feature request]: Support for JSRPC services
- Help with `trace.getActiveSpan()` and `startActiveSpan()` HOT 2
- Bug: Calling a Service Binding RPC method throws a DOMException
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from otel-cf-workers.