ESM interoperability question about otel-cf-workers

[jfsiii]

This "Are the types wrong?" tool is really helpful for types and more general package issues.

It found a few issues

You can also npm pack a local install and upload it to iterate on the changes. There's also a CLI

[evanderkoogh]

Hey! I am absolutely no wizard in module systems either.

But you are absolutely correct in that I would like this to "just work" for everyone.. so certainly going to have a look to see what the best way forward is.

[evanderkoogh]

Ok.. so I have tried to follow the gist of all the module system wizards and it looks like it works now, but I would love for you to give this a go and check if that is indeed actually the case. It was released in 1.0.0-rc3.

[oxcafedead]

@evanderkoogh Thanks for looking at this issue!
Can you please check your index.ts? There are a couple of imports without .js left.

UPD
For now, I decided to fix them manually to see what will be the result (sorry I didn't do it earlier)
Found couple of other places:
sdk.ts (the very bottom):export { waitUntilTrace } from './instrumentation/fetch';
provider.ts: import { AsyncLocalStorageContextManager } from './context'

Then I got another error:

file:///xxx/node_modules/@microlabs/otel-cf-workers/dist/esm/spanprocessor.js:2 
import { stateMachine } from 'ts-checked-fsm';
         ^^^^^^^^^^^^
SyntaxError: Named export 'stateMachine' not found. The requested module 'ts-checked-fsm' is a CommonJS module, which 
may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'ts-checked-fsm';
const { stateMachine } = pkg;

I rewrote the import to

import fsm from 'ts-checked-fsm';
import { getActiveConfig } from './config.js';

const { stateMachine } = fsm;

Then I got:

> npx mocha

ReferenceError: caches is not defined
    at _instrumentGlobalCache (file:///xxx/node_modules/@microlabs/otel-cf-workers/dist/esm/instrumentation/cache.js:67:30)

And this is probably because I try to run tests in a NodeJS runtime where there is no CacheStorage available, because it is not a browser nor a Worker runtime like a Miniflare.

I think I will additionally migrate the tests to wrangler dev to use Miniflare then...

Maybe couple of mentioned imports are worth to fix for consistency, though.

Thanks again.

[evanderkoogh]

Right..

So I just retested 1.0.0-rc.7 and it passed all of the things.

Can you let me know if this still happens?