Downloading is broken about mania

[evan-goode]

Thanks for the issue, sorry for my delayed reply! It's finals season over here. This should be addressed in 842ddc4; I swapped out the old login method for the TV-based login that RedSea does. I'll merge this to master in the next couple days after I update the README and do a little more testing.

I saw you were writing a GUI, and the new login method unfortunately involves some command-line interactivity, see this function:

mania/mania/tidal.py

Line 93 in 842ddc4

def authenticate(self) -> None:

Feel free to PR to do this in a more modular way, it would be cool if the back-endish parts of mania could be easily reused with other interfaces.

[Corewala]

Nice. I tried testing it out and noticed it requires a HiFi subscription to function (I don't have one). Is this due to the new TV-based login system?

[evan-goode]

I commented out the HiFi check in 2897d50, could you give that a try? I copied it over from RedSea without thinking too much about it, but I'm not sure what its purpose is... you would think a non-HiFi account would be able to log in using the same process and fetch lossy tracks. I don't have a non-HiFi account to test :P

[Corewala]

Looks like it can download lossy files now. Thanks!

[Corewala]

I sent a PR with a change to make the authentication system simpler for external clients.

[evan-goode]

Looks like it can download lossy files now. Thanks!

Sweet! Out of curiosity, what happens when you request a track in lossless or MQA quality? Would be good to show an appropriate error in that case.

[Corewala]

-> mania url https://tidal.com/browse/track/101982419 --quality lossless

Loaded cached TIDAL session.
Downloading "Never Gonna Give You Up"...
8.23MB [00:01, 5.03MB/s]                                                                                                                                                                                                                      
Resolving metadata...
Skipping Never Gonna Give You Up.flac; received invalid file
Saving TIDAL session for future use...
Done!

[Corewala]

Oddly enough it does seem to download something, and it is actually playable if you stop mania before it deletes the track. It looks like mania just downloads a high quality lossy track instead.

[evan-goode]

Thanks! Yeah, a silent fail is about what I expected. Added a proper error in 83ea107.

[evan-goode]

Merged to master.