Comments (4)
This appears to be fixed now.
local Promise = require(script.Parent.Lib)
local p = Promise.new(function(_, rej)
error("lol")
end)
p:expect()
05:39:34.234 -- Promise.Error(ExecutionError) --
ServerScriptService.Script:10: lol
ServerScriptService.Script:10
ServerScriptService.Lib:172 function runExecutor
ServerScriptService.Lib:299
Promise created at:
ServerScriptService.Script:9
- Server - Lib:1664
05:39:34.234 Stack Begin - Studio
05:39:34.234 Script 'ServerScriptService.Lib', Line 1664 - function expectHelper - Studio - Lib:1664
05:39:34.234 Script 'ServerScriptService.Lib', Line 1696 - function expect - Studio - Lib:1696
05:39:34.234 Script 'ServerScriptService.Script', Line 13 - Studio - Script:13
05:39:34.234 Stack End - Studio
from roblox-lua-promise.
This is ostensibly a Roblox bug.
I can't fix this, because I have no way to know if the error is going to be displayed to a console for humans or caught by a program and inspected. It would be undesirable for the Promise library to implicitly convert rejection value types.
Going to contact Roblox about this issue and hopefully they can address it on their end.
from roblox-lua-promise.
Hey @jhampton - since you're here... This is still an outstanding issue which makes using the Promise library a little more inconvenient. Do you think you could take a look? There's an open feature request, but it didn't get any response. Thanks!
from roblox-lua-promise.
Sure thing @evaera, I'll take a look!
from roblox-lua-promise.
Related Issues (20)
- Promise:finally counts as a consumer, but it probably shouldn't
- Queued callbacks from a cancelled sub-promise should not be run
- Little typo in :expect() documentation
- Use coroutine.close on cancelled promise threads
- Promise.fold does not return correct value if there is an unresolved Promise in the passed list
- Syntax error in documentation example
- Implement Typings For Strict-Typing Luau Users HOT 7
- Unhandled Promise Rejection warning HOT 6
- coroutine.close issue HOT 2
- retryWithDelay signature is wrong
- Stabilize source field
- Promise wally package throws error "Access is denied. (os error 5)" HOT 1
- `Promise.defer` should use `task.defer` HOT 3
- Cannot publish any library HOT 1
- Promise.all should not error for non-promise input values HOT 1
- Document the Error object and all of its members
- Promise.fromEvent as command HOT 1
- The auto-filling doesn't work? HOT 1
- Error in finally handler does not propagate to subsequent catch after a :timeout HOT 2
- Dependabot Alerts regarding `testez`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roblox-lua-promise.