Comments (1)
These are the contracts that needs commenting divided into three groups
Group 1 (@truls)
- contracts/mocks/TokenXExplicitSenderMock.sol
- contracts/token/TokenX.sol
- contracts/token/ITokenX.sol
- contracts/token/TokenXExplicitSender.sol
- contracts/token/IUpgradableTokenX.sol
- contracts/mocks/ExternalERC20PausableMock.sol
- contracts/token/ERC20/ExternalERC20Pausable.sol
- contracts/mocks/PauserRoleMock.sol
- contracts/mocks/AccesslistGuardedMock.sol
- contracts/mocks/MinterRoleMock.sol
- contracts/mocks/ExternalERC20BurnableMock.sol
Group 2 (@Maasdamind)
- contracts/access/roles/MinterRole.sol
- contracts/mocks/BlacklistAdminRoleMock.sol
- contracts/mocks/BurnerRoleMock.sol
- contracts/access/Accesslist.sol
- contracts/access/AccesslistGuarded.sol
- contracts/token/ERC20/ExternalERC20Mintable.sol
- contracts/mocks/ExternalERC20MintableMock.sol
- contracts/TokenManager.sol
- contracts/mocks/ExternalERC20Mock.sol
- contracts/token/ERC20/ExternalERC20Burnable.sol
Group 3
- contracts/token/ERC20/ExternalERC20Storage.sol
- contracts/access/roles/BurnerRole.sol
- contracts/token/ERC20/ExternalERC20.sol
- contracts/access/roles/PauserRole.sol
- contracts/mocks/WhitelistAdminRoleMock.sol
- contracts/mocks/TokenXMock.sol
- contracts/access/roles/WhitelistAdminRole.sol
- contracts/lifecycle/Pausable.sol
- contracts/access/roles/BlacklistAdminRole.sol
from etoken.
Related Issues (17)
- How to handle permissions?
- Branch naming HOT 1
- Get upgrade address from ENS domain name
- Update the docs with the new minting restriction and it's idea HOT 1
- Reporting on legal opinion and MiFIDII trade-offs.
- Minor changes regarding ETokenExplicitSender.sol (ETokenExplicitSender.sol)
- Proxies calls to an upgraded token do not chain multiple upgrades (EToken.sol)
- Redundant external storage (EToken.sol) HOT 1
- The function latchInitialImplementor() is callable separately from deployment (ExternalERC20Storage.sol)
- Approval events should be fired for transferFrom() and burnFrom() (ExternalERC20.sol)
- Allowance Double-Spend Exploit (ExternalERC20.sol) HOT 2
- Centralization of Power (ExternalERC20Storage.sol)
- Unlocked Pragma
- Refactor to remove redundant functions
- Avoid account permission enforcing modifiers in ExplicitSender functions
- Review comments for public functions in EToken.sol
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from etoken.