Coder Social home page Coder Social logo

Comments (10)

EtienneCmb avatar EtienneCmb commented on May 18, 2024

Why would you like to have a smaller signal on the screen?

from visbrain.

skjerns avatar skjerns commented on May 18, 2024

Some of my recordings have quite low recording range: this makes low amplitudes appear as massive, if they are not not rescaled. This becomes even more a problem if the window is maximized on a large scree0n (=height being the factor).

Example:
capture
For me, the third display is far better and quicker to interpret and spot the spindles. (disregard the uV scale at the left, it is not correct)

Most GUIs I worked with were allowing to rescale the signal as big/small as required. Would that be an idea here as well?

from visbrain.

EtienneCmb avatar EtienneCmb commented on May 18, 2024

I'm not sure to understand your point, from the GUI you can rescale each channel independently. Are talking about the default behavior of the GUI i.e without further configurations?

from visbrain.

skjerns avatar skjerns commented on May 18, 2024

While I can rescale each channel independently, I can't rescale it smaller than a specific factor. Currently the rescaling is limited by the ['max'] of the channel. In my case, the physical ['max'] is denoted as 40.25 (second line). This means I can't set the signal 'smaller' than the middle line in the picture above (maximum amplitde is 40.25). I had to change some parameters in the source to allow a scaling to a maximum amplitude of 90 as in the third signal. Does this make sense? It might be a bit hard to understand what I mean, indeed.

(btw the lines above are 3x the same channel, just with different scaling)

from visbrain.

EtienneCmb avatar EtienneCmb commented on May 18, 2024

Hi @skjerns , sorry for the delay. I think I finally got your point. It's true that the min and max of the GUI elements are defined using the min and max of the data (see this function). But we could allow the user to used values under the min or over the max. We just need to find a range.

from visbrain.

skjerns avatar skjerns commented on May 18, 2024

Why not leave it entirely up to the user, but set a reasonable standard value?
As the user will see immediate feedback on his actions, it's their responsibility to scale it to infinity.

from visbrain.

EtienneCmb avatar EtienneCmb commented on May 18, 2024

At least we could set 10. * min() and 10. * max() this should provide a sufficient range

from visbrain.

skjerns avatar skjerns commented on May 18, 2024

sounds reasonable!

from visbrain.

EtienneCmb avatar EtienneCmb commented on May 18, 2024

Hello @skjerns ,

Sorry for the delay. I recently push a modification (cb36e8a) to limit channel amplitudes to (10 * min, 10 * max). This should fix your issue?

from visbrain.

skjerns avatar skjerns commented on May 18, 2024

it does :) thanks a lot!

from visbrain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.