Coder Social home page Coder Social logo

Comments (7)

Y-Nak avatar Y-Nak commented on September 28, 2024 1

Yes, of course!

from fe.

Y-Nak avatar Y-Nak commented on September 28, 2024 1

So this task includes mentoring from you?

yep!

if you have any guidance on how to start with the parser

Sorry, I made the wrong description for the issue; you don't need to modify the parser. So, the first step for this issue would be to make the name resolution handle the two types properly.

The concrete steps would be

  1. Add usize and isize tohir::hir_def::ident::kw.
  2. Modify hir::hir_def::prim_ty to accommodate those two types(IntTy and UintTy are the places where you would need to modify).
  3. Modify hir::hir_def::PrimTy::all_types so that it includes the newly added usize and isize in step 2.

from fe.

Y-Nak avatar Y-Nak commented on September 28, 2024 1

Oh, currently, the head of v2 is #1007, which will be merged soon.
Please use that branch as a base.

from fe.

lana-shanghai avatar lana-shanghai commented on September 28, 2024

Hey, could I work on this? @Y-Nak

from fe.

lana-shanghai avatar lana-shanghai commented on September 28, 2024

Yes, of course!

Sweet! So this task includes mentoring from you? :) if you have any guidance on how to start with the parser, please share, otherwise I am diving into the codebase for now!

from fe.

Y-Nak avatar Y-Nak commented on September 28, 2024

For the type checker module, the steps would be

  1. Modify hir_analysis::ty::ty_def::PrimTy.
  2. Modify impl From<HirPrimty> for TyBase in ty_def module.

In addition to that, you probably need to modify some auxiliary methods like ty_def::PrimTy::is_integral.

Basically, that'd be all necessary things(I might miss something, though).
Please feel free to ask any questions.

from fe.

Y-Nak avatar Y-Nak commented on September 28, 2024

resolved in #1012

from fe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.