Comments (7)
Yes, of course!
from fe.
So this task includes mentoring from you?
yep!
if you have any guidance on how to start with the parser
Sorry, I made the wrong description for the issue; you don't need to modify the parser. So, the first step for this issue would be to make the name resolution handle the two types properly.
The concrete steps would be
- Add
usize
andisize
tohir::hir_def::ident::kw
. - Modify
hir::hir_def::prim_ty
to accommodate those two types(IntTy
andUintTy
are the places where you would need to modify). - Modify
hir::hir_def::PrimTy::all_types
so that it includes the newly addedusize
andisize
in step 2.
from fe.
Oh, currently, the head of v2
is #1007, which will be merged soon.
Please use that branch as a base.
from fe.
Hey, could I work on this? @Y-Nak
from fe.
Yes, of course!
Sweet! So this task includes mentoring from you? :) if you have any guidance on how to start with the parser, please share, otherwise I am diving into the codebase for now!
from fe.
For the type checker module, the steps would be
- Modify
hir_analysis::ty::ty_def::PrimTy
. - Modify
impl From<HirPrimty> for TyBase
inty_def
module.
In addition to that, you probably need to modify some auxiliary methods like ty_def::PrimTy::is_integral
.
Basically, that'd be all necessary things(I might miss something, though).
Please feel free to ask any questions.
from fe.
resolved in #1012
from fe.
Related Issues (20)
- Implement `std::abi` and use in Fe v2 to provide Contract ABI support
- The fe test command should default to run from the project directory
- Test with assert string panics HOT 1
- Reconsider salsa recovery fn usage
- [FOLLOW UP] Type system
- Failed to Verify Contract HOT 3
- Unexpected event in ABI for compiler v0.26.0 on macOS
- Using fe build without a path should defaut to the root project directory just like fe test does
- Can't run Fe language on M2 MacOS Ventura: bad CPU type in executable HOT 2
- internal error: entered unreachable code', crates/parser/src/lexer/token.rs:313:22
- internal parser error at crates/parser/src/parser.rs:186:9
- Panic due to result::unwrap() called on an `Err` value: TypeError(DiagnosticVoucher(PhantomData<()>)) at crates/analyzer/src/namespace/items.rs:1918:64 HOT 2
- Panic in dependency (Salsa) due to no value set for FileContentQuery(SourceFileId(4294967295))
- Allow ingot dependencies to be resolved via git, ipfs etc HOT 2
- Yul codegen should use relooper algorithm
- Add support for transient storage HOT 4
- Github
- Add support for specifying generic arg in path segment
- [FOLLOW UP] Type check
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fe.