Coder Social home page Coder Social logo

Comments (4)

winsvega avatar winsvega commented on July 30, 2024

event better would be
imagine you have tf in your system path.
you just cd to test folder
tf withdrawals.py
and it runs the test generation into the same folder. or if --output provided to that directory.
same with
tf large_withdrawals.json
to just run a generated test

from execution-spec-tests.

spencer-tb avatar spencer-tb commented on July 30, 2024

To rephrase, currently we have ./filled/[folder/folder/test1, folder/folder/test2, folder/folder/test3] but we require ./filled/[test1, test2, test3]. This makes it difficult add generated tests to a directory that already contains tests where we don't want to add the folder structure generated by tf.

To re-iterate, for tf --output ~/<path_to>/ethereum/tests/BlockchainTests/withdrawals --filler-path ~/<path_to_fillers>/ --test-module withdrawals currently we have:

  • /<path_to>/ethereum/tests/BlockchainTests/withdrawals/withdrawals/withdrawals/test1.json
  • /<path_to>/ethereum/tests/BlockchainTests/withdrawals/withdrawals/withdrawals/test2.json
  • ...

Notice the addition of withdrawals/withdrawals.

I can add --no-structure where tf will only add the .json files and no folder structure: tf --output ~/<path_to>/ethereum/tests/BlockchainTests/withdrawals --filler-path ~/<path_to_fillers>/ --test-module withdrawals --no-structure gives this output:

  • /<path_to>/ethereum/tests/BlockchainTests/withdrawals/test1.json
  • /<path_to>/ethereum/tests/BlockchainTests/withdrawals/test2.json
  • ...

from execution-spec-tests.

spencer-tb avatar spencer-tb commented on July 30, 2024

event better would be imagine you have tf in your system path. you just cd to test folder tf withdrawals.py and it runs the test generation into the same folder. or if --output provided to that directory. same with tf large_withdrawals.json to just run a generated test

I like the idea of this but it would be hard to implement currently. Unless we add another field to tf which when enabled, runs a new section of code in src/ethereum_test_filling_tool/main.py avoiding find_modules(..).

from execution-spec-tests.

winsvega avatar winsvega commented on July 30, 2024

the goal is to put this folder and its contents from this repo
https://github.com/ethereum/execution-spec-tests/tree/main/fillers

into tests repo.
so that tests can be version tracked separately from pyspecs source.

from execution-spec-tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.