Coder Social home page Coder Social logo

Comments (3)

marioevz avatar marioevz commented on September 6, 2024

This test was a result of a client accepting this full blob transaction embedded in a block in a devnet, hence we needed to add this explicit test that has the RLP which embeds the full version of the type-3 transaction.

This test also verifies it via the Engine API, by placing the full blob tx in the transactions list and test it using hive.

I think it would be fair to remove its rlp_decoded field since the rlp_decoded does not match the rlp we are embedding into the test.

from execution-spec-tests.

winsvega avatar winsvega commented on September 6, 2024

I think its a separate class of teats. I had plenty of this type of tests but they are removed from blockchain.

If you remove rlp decoded you make it unexecutable again for those who don't support rlp.

from execution-spec-tests.

winsvega avatar winsvega commented on September 6, 2024

Or lets make it like currently we have been asked to sort bc tests into

ValidBlocks (all blocks are valid)
InvalidBlocks (some blocks are invalid)

Lets ass InvalidRLPBlocks
The one which will not have rlp_decoded as provided rlp is invalid format or violates ethereum structures

from execution-spec-tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.