Unclear meaning 'protected' field exported in transactions about execution-spec-tests

[spencer-tb]

Re - Mario's comment on what the protected field is used for:

It's referring to the two different types of transactions described in EIP-155, and instructs the client on how they should sign the transaction.

If set to false, the transaction should be signed without taking into account any Chain ID info.

If set to true, the transaction should be signed using the method described in the EIP.

[winsvega]

I think it is unclear what this field means. better to print vrs explicitly. or at leas the v signature value.

[marioevz]

I think it is unclear what this field means. better to print vrs explicitly. or at leas the v signature value.

Exactly this is addressed in #163, it adds signature and sender to (a) all calls to t8n and (b) the fixtures directly, and I think we could remove the protected field entirely.

[winsvega]

So we agree that when exporting transaction in the test, just setting v field is enough ( the rest is defined in rlp)
since if someone would want to sign a tx themselvs they will get different rs values anyway it does not make much sense to export rs. but looking at v encoding they can still deduct chainid or determine tx type on old networks

[marioevz]

Fixed by #187