Coder Social home page Coder Social logo

Comments (4)

Piedone avatar Piedone commented on July 18, 2024 1

Great, thank you!

from etch.orchardcore.contentpermissions.

peterkeating avatar peterkeating commented on July 18, 2024

Currently the tenant URL prefix is always added to the redirect URL. Do you think we should make it only include the tenant prefix if the redirect URL is prefixed with "~/"? Definitely worth including a hint to state relative URLs will be prefixed with tenant URL prefixed.

from etch.orchardcore.contentpermissions.

Piedone avatar Piedone commented on July 18, 2024

Ah I see. I think the tilde notation as used throughout ASP.NET and in other parts of Orchard too is a more generic approach (it would also open up the option to not use it deliberately but I don't think that would be a popular use-case).

from etch.orchardcore.contentpermissions.

peterkeating avatar peterkeating commented on July 18, 2024

Agreed it wouldn't be a common use case but if I wanted to redirect to another site (e.g. https://google.co.uk) then currently the code would try to redirect to /tenant-prefix/https://google.co.uk, so that definitely needs resolving. I'll also make sure the tilde is supported too 👍

from etch.orchardcore.contentpermissions.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.